From owner-freebsd-arch@FreeBSD.ORG Tue Dec 27 23:49:21 2011 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D49EB106566B; Tue, 27 Dec 2011 23:49:21 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 935BE8FC0A; Tue, 27 Dec 2011 23:49:21 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:2838:1eb:929f:da87] (unknown [IPv6:2001:7b8:3a7:0:2838:1eb:929f:da87]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id B2E4A5C37; Wed, 28 Dec 2011 00:49:19 +0100 (CET) Message-ID: <4EFA597D.3000508@FreeBSD.org> Date: Wed, 28 Dec 2011 00:49:17 +0100 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: freebsd-current@freebsd.org, freebsd-arch@freebsd.org References: <20111226101040.GA6361@freebsd.org> <20111227010449.GA6244@twoflower.paeps.cx> In-Reply-To: <20111227010449.GA6244@twoflower.paeps.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: [rfc] removing/conditionalising WERROR= in Makefiles X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2011 23:49:21 -0000 On 2011-12-27 02:04, Philip Paeps wrote: > On 2011-12-26 10:10:40 (+0000), Alexander Best wrote: >> i grep'ed through src/sys and found several places where WERROR= was set in >> order to get rid of the default -Werror setting. i tried to remove those >> WERROR= overrides from any Makefile, where doing so did not break tinderbox. >> >> in those cases, where it couldn't be completely removed, i added conditions to >> only set WERROR= for the particular achitecture or compiler, where tinderbox >> did not suceed without the WERROR=. > > Wouldn't it be better to set WARNS=x rather than WERROR=? WERROR= says "this > code has bugs, it breaks tinderbox" whereas WARNS=x says "this code has the > following kind of bugs which break tinderbox". In my opinion, WERROR= says: there are warnings in this code which cannot be fixed right now, due to varying reasons, but we don't want to muffle them entirely, so somebody will eventually fix them in the future (or just delete the code, if it is unmaintained, or unmaintainable, like nve). If you set WARNS to a low level, you can be sure nobody ever sees the warnings, and they will never be fixed. That may be appropriate in some cases, but not the ones I just added WERROR= to. Those are just crufty drivers, that nobody wants to burn their fingers on. :)