From owner-freebsd-stable@FreeBSD.ORG Mon Jun 25 15:35:43 2007 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E942D16A400 for ; Mon, 25 Jun 2007 15:35:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by mx1.freebsd.org (Postfix) with ESMTP id 8415A13C484 for ; Mon, 25 Jun 2007 15:35:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [89.162.146.170] (helo=skuns.kiev.zoral.com.ua) by relay01.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1I2qbN-000CoP-0Y for freebsd-stable@freebsd.org; Mon, 25 Jun 2007 18:35:42 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l5PFZR1T090733 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 25 Jun 2007 18:35:27 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l5PFZX1W072645 for ; Mon, 25 Jun 2007 18:35:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l5PFZWHw072644 for freebsd-stable@freebsd.org; Mon, 25 Jun 2007 18:35:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 25 Jun 2007 18:35:32 +0300 From: Kostik Belousov To: freebsd-stable@freebsd.org Message-ID: <20070625153532.GN2268@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BCHI4S30Oax4KlK/" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: ClamAV version 0.90.2, clamav-milter version 0.90.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on skuns.kiev.zoral.com.ua X-Scanner-Signature: 6dc4245230f22f3abb357b69a6da667e X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1175 [June 25 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Subject: MP-Safe quotas for RELENG_6 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2007 15:35:44 -0000 --BCHI4S30Oax4KlK/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, I backported the MP-Safe quotas patch for RELENG_6. Besides what the title said, it includes several fixes for quotas operation. I would commit the patch based on the users feedback, assuming the re@ would not object. Please, test it. http://people.freebsd.org/~kib/quotagiant/quotas-RELENG_6-20070623-1455.patch Draft version of commit message: MFC: part of rev. 1.412 of sys/kern/vfs_syscalls.c: Remove explicit calls to lock and unlock Giant and replace them with VFS_LOCK_GIANT/VFS_UNLOCK_GIANT calls. MFC this for quotactl only. rev. 1.433 of sys/kern/vfs_syscalls.c: Busy filesystem around call of VFS_QUOTACTL() vfs op. rev. 1.289 of sys/ufs/ufs/ufs_vnops.c: Remove unneeded getinoquota() call in the ufs_access(). rev. 1.83 of sys/ufs/ufs/ufs_lookup.c: Call getinoquota() before allocating new block for the directory to properly account for block allocation. rev. 1.30 of sys/ufs/ufs/quota.h rev. 1.327 of sys/ufs/ffs/ffs_vfsops.c rev. 1.93 of sys/ufs/ufs/ufs_quota.c: Implement fine-grained locking for UFS quotas. rev. 1.205 of sys/ufs/ffs/ffs_softdep.c rev. 1.328 of sys/ufs/ffs/ffs_vfsops.c: Mark UFS as being MP-Safe in "options QUOTA" case too. Remove no more neccessary Giant acquisions in softdepend processing code. rev. 1.206 of sys/ufs/ffs/ffs_softdep.c: Revert rev. 1.205. Replace unconditional acquision of Giant when QUOTAS are defined with VFS_LOCK_GIANT(NULL) call. rev. 1.211 of sys/ufs/ffs/ffs_softdep.c rev. 1.69 of sys/ufs/ufs/ufs_inode.c: Fix livelock that could occur when snapshoting UFS with quotas, where some quota limit was exceeded. --BCHI4S30Oax4KlK/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGf+DCC3+MBN1Mb4gRAqNHAJ9RfY2OnlEJAqsC6s+EiABlGi3ZxQCg2r3R M4O4LlgGPQXnuw/mNJbM8M4= =VXPb -----END PGP SIGNATURE----- --BCHI4S30Oax4KlK/--