From owner-freebsd-current@freebsd.org Sat Apr 9 16:42:46 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D9C3B09561 for ; Sat, 9 Apr 2016 16:42:46 +0000 (UTC) (envelope-from wolfgang@lyxys.ka.sub.org) Received: from saturn.lyxys.ka.sub.org (saturn.lyxys.ka.sub.org [217.29.35.151]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 212A012AB; Sat, 9 Apr 2016 16:42:45 +0000 (UTC) (envelope-from wolfgang@lyxys.ka.sub.org) Received: from juno.lyxys.ka.sub.org (juno.lyx [IPv6:fd2a:89ca:7d54:0:240:caff:fe92:4f47]) by saturn.lyxys.ka.sub.org (8.15.2/8.15.2) with ESMTPS id u39GgRVD024956 (version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=FAIL); Sat, 9 Apr 2016 18:42:28 +0200 (CEST) (envelope-from wolfgang@lyxys.ka.sub.org) Received: from juno.lyxys.ka.sub.org (localhost [127.0.0.1]) by juno.lyxys.ka.sub.org (8.15.2/8.15.2) with ESMTPS id u39GgRIW073161 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 9 Apr 2016 18:42:27 +0200 (CEST) (envelope-from wolfgang@lyxys.ka.sub.org) Received: (from wolfgang@localhost) by juno.lyxys.ka.sub.org (8.15.2/8.15.2/Submit) id u39GgQVr073160; Sat, 9 Apr 2016 18:42:26 +0200 (CEST) (envelope-from wolfgang@lyxys.ka.sub.org) X-Authentication-Warning: juno.lyx: wolfgang set sender to wolfgang@lyxys.ka.sub.org using -f Date: Sat, 9 Apr 2016 18:42:26 +0200 From: Wolfgang Zenker To: John Baldwin Cc: Konstantin Belousov , freebsd-current@freebsd.org, freebsd@grem.de Subject: Re: Acer C720 crash at boot Message-ID: <20160409164226.GB69968@lyxys.ka.sub.org> References: <20160409121004.GA69051@lyxys.ka.sub.org> <20160409132746.GA69968@lyxys.ka.sub.org> <20160409142535.GP1741@kib.kiev.ua> <1560530.UPOY1Ni5U9@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560530.UPOY1Ni5U9@ralph.baldwin.cx> Organization: private site User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (saturn.lyxys.ka.sub.org [IPv6:fd2a:89ca:7d54:1:200:24ff:feca:b4cc]); Sat, 09 Apr 2016 18:42:28 +0200 (CEST) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2016 16:42:46 -0000 Hi, system does not crash with this patch, thanks! * John Baldwin [160409 17:27]: > On Saturday, April 09, 2016 05:25:35 PM Konstantin Belousov wrote: >> On Sat, Apr 09, 2016 at 03:27:46PM +0200, Wolfgang Zenker wrote: >>> Done: http://cid2945g797.hs14.hosting.punkt.de/IMG_3762.JPG >> The immediate cause was the change in r297466, but the code that existed >> there, did not worked. It looks as a bug in ichiic, set_controller() >> use msleep() with timeout too early when compiled into the kernel. > Can you try this change: > diff --git a/sys/dev/ichiic/ig4_iic.c b/sys/dev/ichiic/ig4_iic.c > index a556127..23bdb7d 100644 > --- a/sys/dev/ichiic/ig4_iic.c > +++ b/sys/dev/ichiic/ig4_iic.c > @@ -117,7 +117,10 @@ set_controller(ig4iic_softc_t *sc, uint32_t ctl) > error = 0; > break; > } > - mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); > + if (cold) > + DELAY(1000); > + else > + mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); > } > return (error); > } Wolfgang