From owner-freebsd-toolchain@freebsd.org Tue Dec 15 18:54:06 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02B30A489A9 for ; Tue, 15 Dec 2015 18:54:06 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-211-152.reflexion.net [208.70.211.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B94931985 for ; Tue, 15 Dec 2015 18:54:05 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 32040 invoked from network); 15 Dec 2015 18:54:09 -0000 Received: from unknown (HELO mail-cs-02.app.dca.reflexion.local) (10.81.19.2) by 0 (rfx-qmail) with SMTP; 15 Dec 2015 18:54:09 -0000 Received: by mail-cs-02.app.dca.reflexion.local (Reflexion email security v7.80.0) with SMTP; Tue, 15 Dec 2015 13:54:03 -0500 (EST) Received: (qmail 3511 invoked from network); 15 Dec 2015 18:54:03 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with SMTP; 15 Dec 2015 18:54:03 -0000 X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.1.8] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id 38B9B1C43BC; Tue, 15 Dec 2015 10:54:00 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: 11.0-CURRENT SRC_ENV_CONF file vs. MAKEOBJDIRPREFIX in the file: they do not mix From: Mark Millard In-Reply-To: <56705DEB.2030004@FreeBSD.org> Date: Tue, 15 Dec 2015 10:54:02 -0800 Cc: "Simon J. Gerraty" , FreeBSD PowerPC ML , FreeBSD Toolchain , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <1F2AC0BD-8963-46BA-9C1B-EB5F48CDA204@dsl-only.net> References: <2426.1449521335@chaos> <56675638.5010904@FreeBSD.org> <56705DEB.2030004@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 18:54:06 -0000 On 2015-Dec-15, at 10:37 AM, Bryan Drewery wrote: >=20 > On 12/8/15 2:14 PM, Bryan Drewery wrote: >> On 12/7/15 1:33 PM, Mark Millard wrote: >>>=20 >>>> On 2015-Dec-7, at 12:48 PM, Simon J. Gerraty = wrote: >>>>=20 >>>> Mark Millard wrote: >>>>> My guess is that it is picking up the >>>>>=20 >>>>> MAKEOBJDIRPREFIX=3D/usr/obj/xtoolchain >>>>=20 >>>> You should use ?=3D if you want this to work. >>>> There are many places in Makefile.inc1 where MAKEOBJDIRPREFIX is = tweaked >>>> in the environment of a sub-make. >>>>=20 >>>> By using =3D above, you break that. >>>=20 >>> That presumes that MAKEOBJDIRPREFIX has not been assigned a default = value before the SRC_ENV_CONF file has been included the first time. If = MAKEOBJDIRPREFIX had been defined already then the ?=3D would do nothing = and the wrong value would be used. >>>=20 >>> I believe that the following trace shows that such an assignment of = a default value does happen first, making ?=3D not work either. >>>=20 >>>=20 >>>=20 >>> /usr/src/Makefile (head/Makefile 29160) has >>>=20 >>>> MAKEOBJDIRPREFIX?=3D /usr/obj >>>=20 >>> at line 145 (used when it is not using targets/Makefile from the = relevant .if/.else/.endif). >>>=20 >>> Line 105 has .include and there no others before = the above assignment. bsd.compiler.mk in turn includes bsd.opt.mk = (only), which in turns includes bsd.mkopt.mk (only). That in turn = includes nothing else. So these files and only these files are the = involved files before that assignment as far as I can tell. >>>=20 >>> None of these get to src.sys.env.mk and so SRC_ENV_CONF use has not = happened yet when=20 >>>=20 >>>> MAKEOBJDIRPREFIX?=3D /usr/obj >>>=20 >>> is executed. >>>=20 >>> So, if I understand right, MAKEOBJDIRPREFIX is already defined = before the code >>>=20 >>>> SRC_ENV_CONF?=3D /etc/src-env.conf >>>> .if !empty(SRC_ENV_CONF) && !target(_src_env_conf_included_) >>>> .-include "${SRC_ENV_CONF}" >>>> _src_env_conf_included_: .NOTMAIN >>>> .endif >>>=20 >>> is executed and so using ?=3D would not be effective in the included = file. >>>=20 >>> Did I miss something? >>=20 >>=20 >> Yes. sys.mk and src-env.conf are included *before* Makefile. Think of = it >> as being in line 0. >>=20 >> Technically you should be able to use MAKEOBJDIRPREFIX in make.conf = or >> src.conf if you are not using any of the meta mode features (all off = by >> default). >>=20 >=20 > Clarification: We *could* support this but it does not work today. We > can use .OBJDIR to force using a MAKEOBJDIRPREFIX from make.conf but > only if we also force creating the directory as well. Getting this all > right just ends up falling into the new auto.obj.mk territory anyhow. = I > do want to expand that to the default build, which would allow setting > MAKEOBJDIRPREFIX in src-env.conf. So may be the paragraph below from "man src.conf" should not (yet?) = suggest that MAKEOBJDIRPREFIX is valid in a file to be referenced by = SRC_ENV_CONF: > The environment of make(1) for the build can be controlled via the > SRC_ENV_CONF variable, which defaults to /etc/src-env.conf. Some > examples that may only be set in this file are MAKEOBJDIRPREFIX, > WITH_DIRDEPS_BUILD, and WITH_META_MODE as they are = environment-only > variables. =3D=3D=3D Mark Millard markmi at dsl-only.net