From owner-svn-src-all@freebsd.org Mon Feb 4 20:13:53 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C294F14B0E0A; Mon, 4 Feb 2019 20:13:53 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 209CE70749; Mon, 4 Feb 2019 20:13:53 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x644.google.com with SMTP id b5so448354plr.4; Mon, 04 Feb 2019 12:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uTga1PVbLc7860h/xXknF2BDhOOPg4PPmCq1idadsJg=; b=EjVjXiTHsO861fMd6d1CP4cSqoKqnvMXfJGxR3foDSgNtrx1cPfelw0GVit+Oy97m9 ACpY9UCOyvO0M7VqFmL9ixkXUfBqOD4O2cycsAIxvakJN6ECj9ameltCdGoOxksckn3F qNWjn9gE4cPiLUaMFfwarhQyOlgCZC6yZEnKDWOihba09xHv42yyZFm2DgZB3Q20sBDi NU4ae3DngmtUeJ48l57Pc63Y0UiXThrEUpmx+jbBfLX4/zo6knfq2tlfMUCB/YJzO8Po wZOSdVJrDJCViQx3ddgLmxIMrtHZArvt8qY28qav2TnswAVrBgapZ4sfbVTpivzAUG2g IuVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uTga1PVbLc7860h/xXknF2BDhOOPg4PPmCq1idadsJg=; b=Xc8UMKQ5+LS6zwSwOTm76SndYvtTA2NrpPfn//HVnPFDw/JYoR+MowgKobbyLI+umv JrPQT0YlyoTF142ORt92c0BEUD2ph8AasW4TVVeT1R6k9WuxQ4uBr41aQUI1gnXakn99 nNtteY3u0tqXnZtOGjsYzvLXA9lIauy8JJ3uRO/n5DchRSo2xSNxyc82uAsZ2OObkugt GpjRdgzEtKPvIZblX3f30CnP0FDNLC2+SZ4QnwCfOymKbynoW5jm8qxKDZQ0t+QBHuD9 6kLfv+yl+foNqk9KG7sldCZvQhNJB68JQRrceVYY2+F65IAE3kLfziL+IHAGiHcSpLJU 590A== X-Gm-Message-State: AHQUAubuBntQy+jhAYAcY79lcdP0PzZXlaRZUs9CHq9lnlA/L/OQoEXY UG6dcSYonV5teGnXoWhvK6Er0d4d X-Google-Smtp-Source: AHgI3IbzNEqx6Tmpj9QCixLdqsUWLPX/NUp75t25WvaBAFDw6mDIqRCYLJZim4ZtTSen2WeHkPGXQQ== X-Received: by 2002:a17:902:a60f:: with SMTP id u15mr1101481plq.275.1549311231887; Mon, 04 Feb 2019 12:13:51 -0800 (PST) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id w184sm1065403pgd.34.2019.02.04.12.13.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 12:13:51 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r343751 - head/lib/libc/tests/sys From: Enji Cooper In-Reply-To: <201902042009.x14K9vIJ037929@pdx.rh.CN85.dnsmgr.net> Date: Mon, 4 Feb 2019 12:13:50 -0800 Cc: Enji Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <3CF9638D-9799-4176-97C7-A17A12B0DEC4@gmail.com> References: <201902042009.x14K9vIJ037929@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 209CE70749 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.968,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 20:13:54 -0000 > On Feb 4, 2019, at 12:09 PM, Rodney W. Grimes = wrote: >=20 >> Author: ngie >> Date: Mon Feb 4 19:12:45 2019 >> New Revision: 343751 >> URL: https://svnweb.freebsd.org/changeset/base/343751 >>=20 >> Log: >> Avoid the DNS lookup for "localhost" >>=20 >> ci.FreeBSD.org does not have access to a DNS resolver/network = (unlike my test >> VM), so in order for the test to pass on the host, it needs to avoid = the DNS >> lookup by using the numeric host address representation. >=20 > If it can not get to a resolver, it should be falling back to > /etc/hosts whch does have the correct entries for localhost. Please continue this thread of discussion on Phabricator. This was already discussed sort of there. As I said before (when it was = commented on by @emaste): >> In D19026#407184, @emaste wrote: >> I don't object to this patch but shouldn't we be able to prevent any = DNS use via nsswitch.conf? >> That would require everyone make a corresponding change to prevent = any DNS use when running this test. > It's better to focus on what needs to be tested, instead of what's = nice to test by side-effect. There are other tests that exercise DNS = lookups (which currently fail after a long timeout due to a lacking = external connection). > This is a quick hack to set this test on a working path. The right = path is the suggestion @asomers provided in the previous review, to use = if_tap. Thanks -Enji=