Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Apr 2006 00:53:03 -0700
From:      Nate Lawson <nate@root.org>
To:        Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
Cc:        acpi@freebsd.org, current@freebsd.org
Subject:   Re: CFR: ACPI Dock driver
Message-ID:  <443F54DF.3080809@root.org>
In-Reply-To: <20060413.012156.56054177.iwasaki@jp.FreeBSD.org>
References:  <20060408.032151.07645075.iwasaki@jp.FreeBSD.org>	<20060410.215024.32344167.iwasaki@jp.FreeBSD.org>	<443C027B.7050002@root.org> <20060413.012156.56054177.iwasaki@jp.FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Mitsuru IWASAKI wrote:
> Hi, Thanks for your comments.  Patches for acpi_dock.c are attached.
> 
> One thing,
> 
>> * There also might be an acpi_GetReference() helper function to use.  (I 
>> think I wrote one)
> 
> Sorry, I can't get this.  Could you point this out in detail?
> 
> Thanks!

I looked and found you use acpi_GetReference() already in acpi_dock.c. 
So no idea what I meant, must have misread something.

One other thing:  you explicitly call _INI.  acpi-ca should be doing 
that for you already, is it not?

-- 
Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?443F54DF.3080809>