From owner-svn-src-head@freebsd.org Tue Apr 3 22:35:36 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F81CF8614C; Tue, 3 Apr 2018 22:35:36 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B2F4F792BD; Tue, 3 Apr 2018 22:35:35 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id f698a56e; Wed, 4 Apr 2018 00:28:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h= mime-version:content-type:content-transfer-encoding:date:from:to :cc:subject:in-reply-to:references:message-id; s=mail; bh=NOT2Fn ZYGpUVwE9fHG5K0UllqKo=; b=Mv4lFB2q/VtOiXfa7ewy90cxyjXOnUBTVzyv+M Wpv9dii/dLyjDIew66y56FbNCCuSLbJMntZpmT2fylGDU6cdlO878Xt3l7m+EQLp 27QY9AMvBAkjgDkEsRVf0Kxuri0PfzmiRO/HJa0xJE0t5aXnS2NK+yU1fKAoMogB nq1gg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h= mime-version:content-type:content-transfer-encoding:date:from:to :cc:subject:in-reply-to:references:message-id; q=dns; s=mail; b= dvPrUnM/D//fALJZ7pkRZjFOMBJAPNALdrvi2Zrh57pv6JRcN62KCwxjbjaugnRV 6RTZdb0cHDmXdvR4zRvbaHvooNHlduIzwkswHVSeCfJB0XkCquk55cFYCkTiFPUA Res2CnSW0kTamEvf4nTvzg0+xGDfW0MSEw72X6v7H7U= Received: from webmail.megadrive.org (www1.blih.net [212.83.177.180]) by mail.blih.net (OpenSMTPD) with ESMTP id 2b35bd42; Wed, 4 Apr 2018 00:28:53 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 04 Apr 2018 00:28:53 +0200 From: Emmanuel Vadot To: Marcin Wojtas Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, owner-src-committers@freebsd.org Subject: Re: svn commit: r331961 - in head/sys: arm/mv dts/arm Organization: Bidouilliste In-Reply-To: <201804032221.w33MLDTE019502@repo.freebsd.org> References: <201804032221.w33MLDTE019502@repo.freebsd.org> Message-ID: <5dea78be118fa5ee4b8cb77a1e26a6f0@megadrive.org> X-Sender: manu@bidouilliste.com User-Agent: Roundcube Webmail/1.1.1 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 22:35:36 -0000 On 2018-04-04 00:21, Marcin Wojtas wrote: > Author: mw > Date: Tue Apr 3 22:21:12 2018 > New Revision: 331961 > URL: https://svnweb.freebsd.org/changeset/base/331961 > > Log: > Make Marvell AmadaXP timer driver more generic > > Store pointers to SoC specific functions in mv_timer_config structure > and determine proper config in runtime based on compatible string > from FDT. > Compatible string for ArmadaXP timers is changed to match Linux FDT. > Armada 38x uses generic Cortex-A9 timer and separate watchdog > drivers, so > it does not need to be supported by timer driver. > > Submitted by: Rafal Kozik > Reviewed by: manu > Obtained from: Semihalf > Sponsored by: Stormshield > Differential Revision: https://reviews.freebsd.org/D14741 Hello Marcin, I've only reviewed the DTS part. Also you didn't address andrew@ comment, see https://reviews.freebsd.org/D14741?id=40452#inline-89719 Cheers, -- Emmanuel Vadot