From owner-freebsd-current@FreeBSD.ORG Wed Apr 29 19:17:51 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AEE97106564A; Wed, 29 Apr 2009 19:17:51 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 84D658FC1C; Wed, 29 Apr 2009 19:17:51 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 0354B327D0D; Wed, 29 Apr 2009 14:59:06 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 29 Apr 2009 14:59:06 -0400 X-Sasl-enc: vxac6vQ0gxfZbT8mzkPTCI+o+ZACmeX1H6gFDIgO/JCg 1241031545 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id 50927E61A; Wed, 29 Apr 2009 14:59:05 -0400 (EDT) Message-ID: <49F8A377.3000809@incunabulum.net> Date: Wed, 29 Apr 2009 19:59:03 +0100 From: Bruce Simpson User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Marko Zec References: <49F83633.3080109@incunabulum.net> <200904291351.03408.zec@freebsd.org> In-Reply-To: <200904291351.03408.zec@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: HEADS UP: MLDv2 merge commencing X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2009 19:17:51 -0000 Marko Zec wrote: > IMO don't worry about the vnet struct sizes, julian and I have several more > changes in the pipeline for commiting RSN which will change vnet struct sizes > as well, so after all this gets merged a final commit for settling vnet size > guards #defines can be commited. Thanks for this, I really appreciate it. I am going to push the code in ASAP. I'm concerned that I haven't been able to test this code against a real MLDv2 querier. (Lame I know!) Folk with IPv6 test setups could really help out here -- if you have an IPv6 multicast setup to exercise this code, that would be great. I've tested that the reports appear to be correct. If there's a problem it is probably going to come from scope IDs being embedded on-wire, or possibly getting a test wrong in the input path. We're talking hours/days of latency here for me to get a test tool up and running. I don't like pushing code in too early, but I'm already being pressured to look at other things, so it seems best to get it in and clean up any issues as soon as possible. Normally I wouldn't play fast and loose like this, but it is IPv6 so I am giving myself a bit more leeway this time around :-) cheers, BMS