From owner-freebsd-current@FreeBSD.ORG  Wed May 16 09:59:19 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26389106566B;
	Wed, 16 May 2012 09:59:19 +0000 (UTC)
	(envelope-from mjguzik@gmail.com)
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 836CE8FC0A;
	Wed, 16 May 2012 09:59:18 +0000 (UTC)
Received: by wgbds11 with SMTP id ds11so519210wgb.31
	for <multiple recipients>; Wed, 16 May 2012 02:59:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=date:from:to:cc:subject:message-id:references:mime-version
	:content-type:content-disposition:in-reply-to:user-agent;
	bh=VIqbjbQtbYJcXbfOgVUkPcfC19tkFL9Dxv0TB5CVj1M=;
	b=tijoNqKJ3TZaSGoZjWzQmZNPLNf1PjDnjmao1a7WGzRWg7I+eiA71ffwu8GdgTN60d
	SYUkd9ODZUP3/BlLunNbm9GVzXkJx/ZTTQZBZTEm4pSnZ6DzBIrTC6XavABUgsNPNGo/
	V9t6bfk3V87jQx7YWuiv63jqTwq1DzKqApOzTNqoq6fYUAlvjABDjDfLD924DUNsUx6p
	CrG0nbluIlIiBX0DTA3O3jRAXpdvUuALeh6SnoN9UgMqvwGqrRcrtlqS4uANt8jMLNLf
	06xpEEGweyPyAr7NSP/+LCMHI1qim/ms5ScM4ILQqiKFzIEGGz5B76eJHHQBu6CtjEHi
	h7pQ==
Received: by 10.180.91.225 with SMTP id ch1mr6365694wib.18.1337162356829;
	Wed, 16 May 2012 02:59:16 -0700 (PDT)
Received: from dft-labs.eu (dft-labs.eu. [80.87.128.179])
	by mx.google.com with ESMTPS id o9sm7579152wia.3.2012.05.16.02.59.14
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 16 May 2012 02:59:15 -0700 (PDT)
Date: Wed, 16 May 2012 11:59:09 +0200
From: Mateusz Guzik <mjguzik@gmail.com>
To: Andrew Thompson <thompsa@FreeBSD.org>
Message-ID: <20120516095908.GA2470@dft-labs.eu>
References: <CAFAOGNSFT_pAsj_vfsWQSv1V3SiJq55y+KmWqaftuZwi+0Sr5A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFAOGNSFT_pAsj_vfsWQSv1V3SiJq55y+KmWqaftuZwi+0Sr5A@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: "current@freebsd.org Current" <current@freebsd.org>
Subject: Re: sockstat & jid patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2012 09:59:19 -0000

On Wed, May 16, 2012 at 03:12:50PM +1200, Andrew Thompson wrote:
> Hi,
> 
> 
> Here is a quick patch to limit the sockstat output to a specific jail
> id, this is useful to verify which sockets a jail has open. A jid of 0
> will show the host system.
> 
> This will result in an extra syscall per socket when -j is set but I
> do not think warrants a process cache.
> 
> Any objections?

I think you should extend struct xsocket with jid. Unfortunately this
breaks ABI so MFC is not possible.

That being said, IMHO this patch can be committed to -STABLE if this
feature is that important, but -CURRENT should get implementation
mentioned earlier.

I can try to write a patch in a couple of days (or this evening if I
find the time).

-- 
Mateusz Guzik <mjguzik gmail.com>