From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 22 09:06:20 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3FBD106566B for ; Mon, 22 Nov 2010 09:06:20 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 0E8738FC13 for ; Mon, 22 Nov 2010 09:06:19 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA23347; Mon, 22 Nov 2010 11:06:17 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PKSLp-0008ne-IS; Mon, 22 Nov 2010 11:06:17 +0200 Message-ID: <4CEA328C.2060508@freebsd.org> Date: Mon, 22 Nov 2010 11:06:20 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Paul B Mahol References: <4CE98C7E.90301@freebsd.org> In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: hackers@freebsd.org Subject: Re: Remove printf in acpi_tz_sanity() X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 09:06:20 -0000 on 22/11/2010 01:18 Paul B Mahol said the following: > On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon wrote: >> As is - this is a perfect candidate for a "local only" patch. >> To be included into the tree - this, most probably, has to be controlled by a >> tunable/sysctl. > > So solution for useless console spamming is to add useless sysctl. Are you absolutely sure that they both are/would be useless? For all uses of acpi_tz_sanity()? E.g. if some system has never produced those messages in years and then suddenly starts spewing them out, would that be useless information? > For -1 values, sane default values should be picked up. For current temperature too? > Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for tz0. On your system. > I'm not first one mentioning this and issue is old several years. OK. -- Andriy Gapon