From owner-svn-ports-all@freebsd.org Sun Apr 29 17:59:15 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0BC3FB32BF; Sun, 29 Apr 2018 17:59:15 +0000 (UTC) (envelope-from thierry@pompo.net) Received: from erza.lautre.net (erza.lautre.net [80.67.160.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.lautre.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7B1DD872C5; Sun, 29 Apr 2018 17:59:15 +0000 (UTC) (envelope-from thierry@pompo.net) Received: from graf.pompo.net (graf.pompo.net [78.225.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by erza.lautre.net (Postfix) with ESMTPSA id A2CED257E1; Sun, 29 Apr 2018 19:53:38 +0200 (CEST) Received: by graf.pompo.net (Postfix, from userid 1001) id 9815A361FBA; Sun, 29 Apr 2018 19:53:37 +0200 (CEST) Date: Sun, 29 Apr 2018 19:53:37 +0200 From: Thierry Thomas To: Eitan Adler Cc: Jan Beich , Bernard Spil , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468626 - head/security/libressl Message-ID: <20180429175337.GK72744@graf.pompo.net> Mail-Followup-To: Eitan Adler , Jan Beich , Bernard Spil , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201804291237.w3TCbbjB046542@repo.freebsd.org> <4lju-t6cm-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.1-STABLE amd64 Organization: Kabbale Eros X-Face: (hRbQnK~Pt7$ct`!fupO(`y_WL4^-Iwn4@ly-.,[4xC4xc; y=\ipKMNm<1J>lv@PP~7Z<.t KjAnXLs: X-PGP: 0xF1C516B3C8359753 User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2018 17:59:16 -0000 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Le dim. 29 avr. 18 =E0 19:36:51 +0200, Eitan Adler =E9crivait=A0: > >> security/libressl: Force linking libthr > >> > >> - Fixes problems with loading private ssh keys > > [...] > >> +LDFLAGS+=3D -lthr > > > > Better use -lpthread in case user have different POSIX threads implemen= tation. > > Probably only affects downstream as FreeBSD dropped libkse, libc_r year= s ago. >=20 > Further nit: -pthread not -lpthread. The primary difference is some > preprocessor flags such as _REENTRANT and __USE_REENTRANT 1. We used to have a PTHREAD_LIBS variable (along with PTHREAD_CFLAGS); why did they disappear? --=20 Th. Thomas. --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJa5gahXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFNTM2QkU4NTM4NTM5OUQwMEI2RkFBNzZG MUM1MTZCM0M4MzU5NzUzAAoJEPHFFrPINZdTAQ8P/iakOwWXgGMGiQ6fv30j/nfb c7DpU/uXS76+tloABszTWpGqCJK8WJ38SjwYRvc850ZNx1nQGyhkfAsrEN9Drxda Y4CzIvLx2ljC6bpKFz8toJ/9teXaKLD97h+fu8reW2l1yH4UK/2HrD20V6pVMkdI 1z6S8B8D6joJa2VJVf4TyySqPcPaxtbOb7q736b95/HcsA28ATs+LWUg/tNu9TIi Rqd+tiHJnMcdn6sE2EKKBBk6PBMECV8zlgmG9/oZB/a+IY+jb3tLiRmVyxVTxpL4 cZVphHJm4V2vOwCFx+MMwd/Cz0/y1zSnFhu3eyX1Ep/+VcmtrquIjIed94ZCa04b iH9/VR3k8GoT1I1+CkJdMk6c19opvPPdxCoM1PmtFULTfIaiOX/yI/IA1YqClan3 JCxvjSALZCPy6TR1AhT2ql8xQgcxsxdSEAYilnmPujvtYZfpREnvErHlKkxKaWjh SwCe0nDRKyXcdjHU9+v+nb4pfw5udpEbdy0CkhQumE7Cci2P16kVJ/o3MOh0YyhV r5gdeFx2BRNKRArdMUpM56jEC4Cee/1OaOX7NvNuCvc9XTFIMNDg0jeTmkVy9yaK mvLLqo8BfsmuJAq5zyStO16R77xkt6MrtKP0ukMw+M9cDOg8IttHLtxt1jBPrtrK +VSUhK7xbA26gB8fDDvM =p07U -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--