From nobody Wed Mar 4 15:22:59 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQxJ84TCZz6Tdtj for ; Wed, 04 Mar 2026 15:23:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQxJ83y8Bz3lLp for ; Wed, 04 Mar 2026 15:23:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772637784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=29Btjg5h7TYmIvBoeQvaIi3UW4lYNP6a2eNXqGl0Ln4=; b=ji8fk4XCeNNbhBj9JuT/n4F8U6rKXaVVJIFPy8AbXTFMbtlaDf4J+NpUDMLeD5s8Ja6pk7 L8BDNZT52eP/sd+66OVc5slJIO4ewKxjXkj8Qq3kplfzRfm3+0eaDCjP5lw8duqoDZHs0x oxPQltDkTeMEMJATLnCuKy38Yt1SYKFveDZymR8iug06Wl6E416BnQBILq3z09KHCWyRfL t+GzbMtG91LwNprGkfkZq8aCoP/TtJqvRNptvDXKQ8qExqCkGMMuzhivYQg/NEVmPGo7cl TSNLAo62ZE7esDLLc+Vtxxl9QBLvGE2cQl4PHlk8SNQFqczRqS5bpG+gZqf8dQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772637784; a=rsa-sha256; cv=none; b=nJ81DbNlX7rwSP8IHzmP63u3xHoObv2IwvANioK0FKISOIJXmeZr7JM+xpBItNnl4v8pnm GhJIzr4aCeFb4h2atEmJhgUSdTw5PuQBS7gzqwyiVKi950VKh3sIaZMpatsCelwRaEygP1 MsGz8+srZngvB4E2xSlfl8zHIyZzi8/4b7mnqu80zRHPdwofB1EMuym8s+3LbD16rPgl3L f+PACrEdI1MiudtMYcCHZW8zR7ty2tyh9sLxhcVfgDsn5YIuZ4jHQjexTZf1L0MFxvd9hO O1cQChPneS1fJJdxtsu7H9XQQlnKZuQZUG9GvVTNoY6dBVNfdGgjErr2D/CJ5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772637784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=29Btjg5h7TYmIvBoeQvaIi3UW4lYNP6a2eNXqGl0Ln4=; b=TvHCDuVcGgny1aDp8ivPlgQv9b2ovZ/mU18GTRJl+zq925zQh1uXQm0jTSZylecW4V1O1F 0pV3wiC1jBP/02Dv3Zd9G8FO773yhmDSFCKybIM2Sve6noW88vH0GID8xCmBGPfKAqqqz1 l358gbApLm/GGFCa1CKnTlkGv6xzuz/1QGrkJVVrQGLXT+G9YgC315Eu2rEUACt4Pz7U3w wMS0nOoqmCkDAPdmgT+Swcj55e3AM04Uk6O6S7Fgq7O0JZBTDA6V5Isp9fVn+ysFeb+HqD RuHnnb/qvlvJ7pKACwnzRGQAGx3xzlKRq5Z8xJBtLXDdAB2m8jdMTc1jMCcX1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fQxJ83WMlzx4K for ; Wed, 04 Mar 2026 15:23:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 317d4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Mar 2026 15:22:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 40e52e0edd03 - main - system(3): Unwrap execve() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 40e52e0edd038460a2a2aca017b3ac5a513fe37b Auto-Submitted: auto-generated Date: Wed, 04 Mar 2026 15:22:59 +0000 Message-Id: <69a84e53.317d4.78cb8c78@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=40e52e0edd038460a2a2aca017b3ac5a513fe37b commit 40e52e0edd038460a2a2aca017b3ac5a513fe37b Author: Dag-Erling Smørgrav AuthorDate: 2026-03-04 15:22:42 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-03-04 15:22:42 +0000 system(3): Unwrap execve() There is no need to call execl(), which will allocate an array and copy our arguments into it, when we can use a static array and call execve() directly. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D55648 --- lib/libc/stdlib/system.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/libc/stdlib/system.c b/lib/libc/stdlib/system.c index 94f7460c9b68..a2f472502bfd 100644 --- a/lib/libc/stdlib/system.c +++ b/lib/libc/stdlib/system.c @@ -60,6 +60,8 @@ __libc_system(const char *command) static struct sigaction ointact, oquitact; struct sigaction ign; sigset_t sigblock, osigblock; + char *argv[] = { "sh", "-c", __DECONST(char *, command), NULL }; + extern char **environ; int pstat = -1, serrno = 0; pid_t pid; @@ -101,7 +103,7 @@ __libc_system(const char *command) /* * Exec the command. */ - execl(_PATH_BSHELL, "sh", "-c", command, NULL); + _execve(_PATH_BSHELL, argv, environ); _exit(127); } else { /* parent */ /*