Date: Sun, 21 Dec 2008 15:47:32 -0800 From: "Li, Qing" <qing.li@bluecoat.com> To: "Julian Elischer" <julian@elischer.org>, "Hartmut Brandt" <hartmut.brandt@dlr.de> Cc: Gerald Pfeifer <gerald@pfeifer.com>, Vladimir Grebenschikov <vova@fbsd.ru>, Kip Macy <kip.macy@gmail.com>, Qing Li <qingli@freebsd.org>, freebsd-current@freebsd.org, freebsd-net@freebsd.org Subject: RE: HEADSUP: arp-v2 has been committed Message-ID: <B583FBF374231F4A89607B4D08578A431442E5@bcs-mail03.internal.cacheflow.com> References: <200812150634.mBF6YDVC060565@freefall.freebsd.org> <873agpk11i.fsf@kobe.laptop> <1229691231.1818.53.camel@localhost> <alpine.LSU.1.99.0812210459130.16577@acrux.dbai.tuwien.ac.at> <3c1674c90812202300y6dc37e89l7936880179f140b5@mail.gmail.com> <494E7481.1090606@dlr.de> <494EA44E.4030303@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In earlier versions I had the kernel returning RTF_LLINFO back to
the calling applications to provide a bit of compatibility. It's
fairly straightforward for me to put that code back in.=20
The change is tiny in the application in majority of the cases=20
that I have seen. If these flags are obsolete and to be sure they
won't linger forever, perhaps the right thing to do is removing=20
them and fix the applications as appropriate in 8.0 release.=20
-- Qing
-----Original Message-----
From: owner-freebsd-net@freebsd.org on behalf of Julian Elischer
Sent: Sun 12/21/2008 12:17 PM
To: Hartmut Brandt
Cc: Gerald Pfeifer; Vladimir Grebenschikov; Kip Macy; Qing Li; =
freebsd-current@freebsd.org; freebsd-net@freebsd.org
Subject: Re: HEADSUP: arp-v2 has been committed
=20
Hartmut Brandt wrote:
> Kip Macy wrote:
>> The flag is not needed. It is only possible to retrieve arp entries =
by
>> way of sysctl. The converse of this is you no longer need to grab all
>> the entries in the routing table and look at each one to determine
>> which are cloned routes (dynamic host routes) which contain ARP
>> entries.
>=20
> Does this mean that the snmp daemon cannot monitor the arp entries=20
> through the routing socket anymore? This would be a performance issue, =
> since it would have to fetch the ARP table from the kernel each time =
it=20
> is asked for. Now it refreshes the table only if it is older than 30=20
> seconds and in the mean time monitors routing messages.
this is one of the things that worried me abuot the arp change, which=20
is is that the change itself is fine but that I had no idea if LLINFO
was BSD specific or if other ports and 3rd party code would rely on=20
the connection between routing and ARP.
maybe ARP activity should produce routing socket events.
and maybe teh output should synthesize the missing entries.
>=20
> harti
>=20
>>
>> -Kip
>>
>> On Sat, Dec 20, 2008 at 9:01 PM, Gerald Pfeifer <gerald@pfeifer.com>=20
>> wrote:
>>> The code in question on the Wine side is
>>>
>>> #if defined(HAVE_SYS_SYSCTL_H) && defined(NET_RT_DUMP)
>>> int mib[] =3D {CTL_NET, PF_ROUTE, 0, AF_INET, NET_RT_FLAGS, =
RTF_LLINFO};
>>>
>>> and there is nothing FreeBSD-specific in dlls/iphlpapi/ipstats.c as =
far
>>> as I can see.
>>>
>>> If the arp-v2 update now made us incompatible both with earlier =
versions
>>> of FreeBSD and Linux, that sounds like something that should be =
fixed
>>> (instead of hacking applications like Wine).
>>>
>>> On the other hand, the commit message at
>>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/net/route.h
>>> explicitly says
>>> The change in design obsoletes the semantics of RTF_CLONING,
>>> RTF_WASCLONE and RTF_LLINFO routing flags. The userland =
applications
>>> such as "arp" and "ndp" have been modified to reflect those =
changes.
>>> so I guess it's not so easy.
>>>
>>> How many other ports are affected?
>>>
>>> What shall we do on the Wine front? Simply #ifdef-ing out the code =
in
>>> question may not be the best of ideas, either. :-(
>>>
>>> Gerald
>>>
>>> On Fri, 19 Dec 2008, Vladimir Grebenschikov wrote:
>>>> On Mon, 15 Dec 2008 06:34:13 GMT, Qing Li <qingli@freebsd.org> =
wrote:
>>>>
>>>>>> The arp-v2 changes have been committed into HEAD.
>>>>>> Please report problems to me and Kip Macy.
>>>> Wine is not build any more:
>>>>
>>>> ...
>>>> cc -c -I. -I. -I../../include -I../../include -D__WINESRC__ =20
>>>> -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing=20
>>>> -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith=20
>>>> -I/usr/local/include -O2 -pipe -fno-strict-aliasing -o ipstats.o=20
>>>> ipstats.c
>>>> ipstats.c: In function 'getNumArpEntries':
>>>> ipstats.c:1253: error: 'RTF_LLINFO' undeclared (first use in this=20
>>>> function)
>>>> ipstats.c:1253: error: (Each undeclared identifier is reported only =
>>>> once
>>>> ipstats.c:1253: error: for each function it appears in.)
>>>> ipstats.c: In function 'getArpTable':
>>>> ipstats.c:1311: error: 'RTF_LLINFO' undeclared (first use in this=20
>>>> function)
>>>> ipstats.c:1311: warning: initialization makes integer from pointer=20
>>>> without a cast
>>>> gmake[2]: *** [ipstats.o] ?????? 1
>>>> gmake[2]: Leaving directory=20
>>>> `/usr/ports/emulators/wine/work/wine-1.1.10/dlls/iphlpapi'
>>>> gmake[1]: *** [iphlpapi] ?????? 2
>>>> gmake[1]: Leaving directory=20
>>>> `/usr/ports/emulators/wine/work/wine-1.1.10/dlls'
>>>> gmake: *** [dlls] ?????? 2
>>>>
>>>>
>>> --=20
>>> Gerald (Jerry) Pfeifer gerald@pfeifer.com =20
>>> http://www.pfeifer.com/gerald/
>>> _______________________________________________
>>> freebsd-net@freebsd.org mailing list
>>> http://lists.freebsd.org/mailman/listinfo/freebsd-net
>>> To unsubscribe, send any mail to =
"freebsd-net-unsubscribe@freebsd.org"
>>>
>>
>>
>>
>=20
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B583FBF374231F4A89607B4D08578A431442E5>