From owner-svn-src-head@FreeBSD.ORG Tue Mar 6 11:34:43 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D9F161065676; Tue, 6 Mar 2012 11:34:43 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 961E68FC18; Tue, 6 Mar 2012 11:34:43 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:c159:bac:b18f:a901] (unknown [IPv6:2001:7b8:3a7:0:c159:bac:b18f:a901]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id CBEBD5C37; Tue, 6 Mar 2012 12:34:42 +0100 (CET) Message-ID: <4F55F652.2040908@FreeBSD.org> Date: Tue, 06 Mar 2012 12:34:42 +0100 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120229 Thunderbird/11.0 MIME-Version: 1.0 To: John Baldwin References: <201203051953.q25JrIS1002269@svn.freebsd.org> In-Reply-To: <201203051953.q25JrIS1002269@svn.freebsd.org> X-Enigmail-Version: 1.4a1pre Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232570 - head/sys/boot/i386/boot2 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 11:34:44 -0000 On 2012-03-05 20:53, John Baldwin wrote: > Author: jhb > Date: Mon Mar 5 19:53:17 2012 > New Revision: 232570 > URL: http://svn.freebsd.org/changeset/base/232570 > > Log: > Fix boot2 to handle boot config files that only contain a custom path to > a loader or kernel. Specifically, kname cannot be pointed at cmd[] since > it's value is change to be an empty string after the initial call to > parse, and cmd[]'s value can be changed (thus losing a prior setting for > kname) due to user input at the boot prompt. While here, ensure that that > initial boot config file text is nul-terminated, that ops is initialized > to zero, and that kname is always initialized to a valid string. Sigh, this broke building boot2 with clang again... :(