From owner-freebsd-bugs@FreeBSD.ORG Wed Jun 4 15:00:30 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0828837B401 for ; Wed, 4 Jun 2003 15:00:30 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4B4D43FCB for ; Wed, 4 Jun 2003 15:00:28 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h54M0SUp043007 for ; Wed, 4 Jun 2003 15:00:28 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h54M0Si6043006; Wed, 4 Jun 2003 15:00:28 -0700 (PDT) Resent-Date: Wed, 4 Jun 2003 15:00:28 -0700 (PDT) Resent-Message-Id: <200306042200.h54M0Si6043006@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Priit Piipuu Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3413437B404 for ; Wed, 4 Jun 2003 14:54:38 -0700 (PDT) Received: from 213-219-88-89-dsl.lsn.estpak.ee (213-219-88-89-dsl.lsn.estpak.ee [213.219.88.89]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C51B43FAF for ; Wed, 4 Jun 2003 14:54:30 -0700 (PDT) (envelope-from priitp@213-219-88-89-dsl.lsn.estpak.ee) Received: from 213-219-88-89-dsl.lsn.estpak.ee (localhost.meskaliin [127.0.0.1])h550XGTq033367 for ; Thu, 5 Jun 2003 00:33:20 GMT (envelope-from priitp@213-219-88-89-dsl.lsn.estpak.ee) Received: (from priitp@localhost)h550XBeD033366; Thu, 5 Jun 2003 00:33:11 GMT Message-Id: <200306050033.h550XBeD033366@213-219-88-89-dsl.lsn.estpak.ee> Date: Thu, 5 Jun 2003 00:33:11 GMT From: Priit Piipuu To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: misc/52954: [PATCH] Unbreak the share/examples/kld/cdev X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Priit Piipuu List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2003 22:00:30 -0000 >Number: 52954 >Category: misc >Synopsis: [PATCH] Unbreak the share/examples/kld/cdev >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 04 15:00:28 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Priit Piipuu >Release: FreeBSD 5.1-BETA i386 >Organization: >Environment: System: FreeBSD minerva 5.1-BETA FreeBSD 5.1-BETA #24: Wed May 21 00:14:22 GMT 2003 root@minerva:/usr/obj/usr/src/sys/tuum i386 >Description: Currently, cdevmod.c produces lots of warnings when compiled, and cdev.ko panics the system when loaded. Seems, that struct cdevsw has changed since the last commit to this file. >How-To-Repeat: cd share/examples/kld/cdev && make all >Fix: --- patch begins here --- --- module/cdevmod.c.orig Mon Oct 2 14:14:06 2000 +++ module/cdevmod.c Thu Jun 5 00:14:18 2003 @@ -78,20 +78,18 @@ #define CDEV_MAJOR 32 static struct cdevsw my_devsw = { - /* open */ mydev_open, - /* close */ mydev_close, - /* read */ mydev_read, - /* write */ mydev_write, - /* ioctl */ mydev_ioctl, - /* poll */ nopoll, - /* mmap */ nommap, - /* strategy */ nostrategy, - /* name */ "cdev", - /* maj */ CDEV_MAJOR, - /* dump */ nodump, - /* psize */ nopsize, - /* flags */ D_TTY, - /* bmaj */ -1 + /* open */ .d_open = mydev_open, + /* close */ .d_close = mydev_close, + /* read */ .d_read = mydev_read, + /* write */ .d_write = mydev_write, + /* ioctl */ .d_ioctl = mydev_ioctl, + /* poll */ .d_poll = nopoll, + /* mmap */ .d_mmap = nommap, + /* strategy */ .d_strategy = nostrategy, + /* name */ .d_name = "cdev", + /* maj */ .d_maj = CDEV_MAJOR, + /* dump */ .d_dump = nodump, + /* flags */ .d_flags = D_TTY, }; /* --- test/testcdev.c.orig Sat Dec 9 09:35:39 2000 +++ test/testcdev.c Thu Jun 5 00:14:18 2003 @@ -75,6 +75,7 @@ #include #include #include +#include #include #define CDEV_IOCTL1 _IOR('C', 1, u_int) --- patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: