From owner-cvs-all@FreeBSD.ORG Mon Apr 12 10:25:13 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A069316A4CE; Mon, 12 Apr 2004 10:25:13 -0700 (PDT) Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A7AE43D48; Mon, 12 Apr 2004 10:25:13 -0700 (PDT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (localhost [127.0.0.1]) i3CHPBOY047241; Mon, 12 Apr 2004 19:25:11 +0200 (CEST) (envelope-from marius@newtrinity.zeist.de) Received: (from marius@localhost) by newtrinity.zeist.de (8.12.10/8.12.10/Submit) id i3CHP5QY047240; Mon, 12 Apr 2004 19:25:05 +0200 (CEST) (envelope-from marius) Date: Mon, 12 Apr 2004 19:25:05 +0200 From: Marius Strobl To: "Brian F. Feldman" Message-ID: <20040412192505.A93652@newtrinity.zeist.de> References: <200404121551.i3CFpck3051628@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200404121551.i3CFpck3051628@green.homeunix.org>; from green@freebsd.org on Mon, Apr 12, 2004 at 11:51:37AM -0400 X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.25.0.2; VDF 6.25.0.10 (host: newtrinity.zeist.de) cc: cvs-ports@freebsd.org cc: Alexander Leidinger cc: cvs-all@freebsd.org cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/sysutils/cdrtools-devel Makefile distinfo pkg-descr.mkisofs pkg-plist ports/sysutils/cdrtools-devel/files patch-ai patch-bb patch-cdda2wav::interface.c patch-cdda2wav::ioctl.c patch-cdda2wav::mycdrom.h patch-cdda2wav::setuid.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2004 17:25:13 -0000 On Mon, Apr 12, 2004 at 11:51:37AM -0400, Brian F. Feldman wrote: > FWIW, now that it's updated to 2.01a27, you can very easily add the "DVD > hack": > > +PATCH_SITES= http://people.mandrakesoft.com/~warly/files/cdrtools/archives/ > +PATCHFILES= ${DISTNAME}-dvd.patch.bz2 > +PATCH_DIST_STRIP= -p1 > ... > +MD5 (cdrtools-2.01a27-dvd.patch.bz2) = de1bdde2b406c27798e21b04345a9a0a > +SIZE (cdrtools-2.01a27-dvd.patch.bz2) = 12484 > > I haven't tried everything with it yet, but being that I could at least burn > a DVD+RW at 4x with ATAPICAM it seems like something we should at least make > optional... > No, tried that in the past (see Makefile revision 1.50 - 1.52) and didn't work well (from the port's point of view). a) There's not always a DVD-patch for the current alpha snapshot available. Have a look at the above URL, there were no patches for e.g. 2.01a17 - 2.01a19 and 2.01a21 - 2.01a24. This means if the patch for the previous version no longer applies and there's no updated patch available (which happens often) I have to either delay a port update or remove the DVD-patch-option until a new version of the patch is available or create my own patch - all no good solutions. b) The quality of the DVD-patch is bad, there are obvious bugs (tried to fix some via an EXTRA_PATCHES while the port had an option for the DVD-patch). c) Patching cdrecord means there's absolutely no support for it by its author Joerg Schilling, something I don't want for the port. If you want to write DVDs please use a tool that's written for it, like e.g. burncd(8), cdrecord-ProDVD, dvd+rw-tools or dvdrtools (note that the latter is a fork of cdrecord which violates the GPL according to Joerg Schilling).