From owner-freebsd-stable@FreeBSD.ORG  Tue Feb  4 22:09:59 2014
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A0F56B4C;
 Tue,  4 Feb 2014 22:09:59 +0000 (UTC)
Received: from khavrinen.csail.mit.edu (khavrinen.csail.mit.edu
 [IPv6:2001:470:8b2d:1e1c:21b:21ff:feb8:d7b0])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 67B151210;
 Tue,  4 Feb 2014 22:09:59 +0000 (UTC)
Received: from khavrinen.csail.mit.edu (localhost [127.0.0.1])
 by khavrinen.csail.mit.edu (8.14.7/8.14.7) with ESMTP id s14M9v7P098695
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256
 verify=FAIL CN=khavrinen.csail.mit.edu issuer=Client+20CA);
 Tue, 4 Feb 2014 17:09:57 -0500 (EST)
 (envelope-from wollman@khavrinen.csail.mit.edu)
Received: (from wollman@localhost)
 by khavrinen.csail.mit.edu (8.14.7/8.14.7/Submit) id s14M9vMo098692;
 Tue, 4 Feb 2014 17:09:57 -0500 (EST) (envelope-from wollman)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <21233.25909.355102.743155@khavrinen.csail.mit.edu>
Date: Tue, 4 Feb 2014 17:09:57 -0500
From: Garrett Wollman <wollman@csail.mit.edu>
To: "Kenneth D. Merry" <ken@freebsd.org>
Subject: Re: Heap overflow in mps(4) (was: Re: stable/9 mps(4) rev 254938 ==
 BOOM!)
In-Reply-To: <20140131003342.GA11755@nargothrond.kdm.org>
References: <21225.19508.683025.581620@khavrinen.csail.mit.edu>
 <201401292137.s0TLbD5G006716@hergotha.csail.mit.edu>
 <20140129221514.GA47535@nargothrond.kdm.org>
 <21225.38749.179621.454579@khavrinen.csail.mit.edu>
 <20140131003342.GA11755@nargothrond.kdm.org>
X-Mailer: VM 7.17 under 21.4 (patch 22) "Instant Classic" XEmacs Lucid
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (khavrinen.csail.mit.edu [127.0.0.1]); Tue, 04 Feb 2014 17:09:57 -0500 (EST)
Cc: freebsd-scsi@freebsd.org, scottl@freebsd.org, freebsd-stable@freebsd.org
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 22:09:59 -0000

<<On Thu, 30 Jan 2014 17:33:42 -0700, "Kenneth D. Merry" <ken@freebsd.org> said:

> The fact that the redzone code doesn't expose any problems makes it more
> likely that it is a problem other than a heap overflow.

So I built a new kernel with DEBUG_MEMGUARD.  When
vm.memguard.desc="mps", everything works fine both through two
load/unload cycles and statically compiled into the kernel.  When
vm.memguard.desc is not set, instapanic as before.  (I'm trying
memguard rather than redzone as it has much less of a performance
impact, so I can start doing some of the performance testing I was
originally intending to do.

Are there any debugging options that I could usefully enable that
would show just what mps is doing when the fault happens?  I see that
there are lots of tracing options but I don't know what would actually
be useful.

-GAWollman