From nobody Tue Aug 8 08:09:55 2023 X-Original-To: freebsd-mips@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RKm804Lcqz4Tspb for ; Tue, 8 Aug 2023 08:10:08 +0000 (UTC) (envelope-from mizhka@gmail.com) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RKm802Myvz4Jjs for ; Tue, 8 Aug 2023 08:10:08 +0000 (UTC) (envelope-from mizhka@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-52164adea19so6941644a12.1 for ; Tue, 08 Aug 2023 01:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691482207; x=1692087007; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aMf85ykzTAyh47Rc2MUF3KYNwEdZI8jC4DXBpXdbte0=; b=oHl24UDxtIuHDXWkMXm0eCBznPI66R4Xikbc/CGA58Cbs+3Hp7snbj08uCxNYNj5Tv 2NEVqXrosTFcxdw8e+VbkSvCG7bZvUAyuAUByLkqJFP+etokE88NUrho0n/poisnGn36 9nhTwUlWoS4XydlZlGnDcfbGwOThx8ekBFMk6CHIhkctMZEEHyMdztSSzuB6hxrn1fIb ttMVArP/zR1oxzwEcw8Pg0LRWrMPiMcEee4+E8ib8BppQrhPc5mh3smtZAVLhuuY2pTx +CzbWsRAzSu5LoTqww3Wq3+VewvNIThd4Szh5WhKmOf/0V+VxI4wxmzXnOFFhG1f6qAi UgBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691482207; x=1692087007; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aMf85ykzTAyh47Rc2MUF3KYNwEdZI8jC4DXBpXdbte0=; b=GRcrmzNNTfZBUsae5GTa4ybMjK3fniwL1LxygsJSKZSiLvmkW4hvAkoBq0bMkx42xo 74X+K9EBkVi1lC8XmO/yFhdzp1/1vQd5N6t9U7NwlL3FpLEanAyGST5yCqjYkhALJK68 W8IvC5FMiHIRUm7do+6x9B5kH1OGONgQuh80AEBz+PEQFjf1sJLXoFStI0ysIFhvCvwL A4flS2DQnNQbc77qBj9Qo9O7XK9ewhqhXdQTZrj6Z6wci4CBnUaXLhy7gdKxfEN08dn/ 0V0Uh4PxGFDeJis7WzA/qvNdnG5eDnmRiYxNotCMbX1Sa5UDHQgsO46YDGY0vlDEDCIh 5sNw== X-Gm-Message-State: AOJu0YwqmZ1Sogf5vbKRC+UamOsJCdZkysg7hNEf8qNvszjk11okNcwe bx6K/rrQigdI0aLP8RotVr5Rc2gtPLkbv5zUyCVN2Ef+ X-Google-Smtp-Source: AGHT+IH3LBg7jdtZGf7wZ70dnEyiy3UwCMztbhAgqKKZkyhJKB1rZDpk+0OrmxASXQIwpmWMIZk1cSAtqLUhQF7N95M= X-Received: by 2002:aa7:c651:0:b0:522:3ea4:81a9 with SMTP id z17-20020aa7c651000000b005223ea481a9mr9464097edr.34.1691482206714; Tue, 08 Aug 2023 01:10:06 -0700 (PDT) List-Id: Porting FreeBSD to MIPS List-Archive: https://lists.freebsd.org/archives/freebsd-mips List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-mips@freebsd.org MIME-Version: 1.0 References: <432826271.241756.1691477064075.JavaMail.yahoo.ref@mail.yahoo.co.jp> <432826271.241756.1691477064075.JavaMail.yahoo@mail.yahoo.co.jp> In-Reply-To: <432826271.241756.1691477064075.JavaMail.yahoo@mail.yahoo.co.jp> From: Michael Zhilin Date: Tue, 8 Aug 2023 11:09:55 +0300 Message-ID: Subject: Re: wrong code in arswitch. To: Mori Hiroki Cc: "freebsd-mips@freebsd.org" Content-Type: multipart/alternative; boundary="00000000000013412f060264e4b1" X-Rspamd-Queue-Id: 4RKm802Myvz4Jjs X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --00000000000013412f060264e4b1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Nice catch, thank you! Committed to main, mfc after 1 week. Thank you! On Tue, Aug 8, 2023 at 9:44=E2=80=AFAM Mori Hiroki = wrote: > Hi. > > Now I do port etherswitch function to NetBSD. > > I found wrong code. > > > https://cgit.freebsd.org/src/tree/sys/dev/etherswitch/arswitch/arswitch.c= #n129 > > shift is '>>' > > This value is not use in the code. This no effect. > > Regards > > This is we say Okamehachimoku. > > Hiroki Mori > > > --00000000000013412f060264e4b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Nice catch, thank you!
Committed to main, mfc after 1 week.

Than= k you!

On Tue, Aug 8, 2023 at 9:44=E2=80=AFAM Mori Hiroki <yamori813@yahoo.co.jp> wrote:
Hi.

Now I do port etherswitch function to NetBSD.

I found wrong code.

https://cgit.freebsd.o= rg/src/tree/sys/dev/etherswitch/arswitch/arswitch.c#n129

shift is '>>'

This value is not use in the code. This no effect.

Regards

This is we say Okamehachimoku.

Hiroki Mori


--00000000000013412f060264e4b1--