Date: Mon, 15 Nov 2010 12:24:06 +1100 From: Lawrence Stewart <lstewart@freebsd.org> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r215166 - in head: . sys/conf sys/netinet sys/netinet/cc sys/sys Message-ID: <4CE08BB6.1090304@freebsd.org> In-Reply-To: <86pqu8q6lb.fsf@kopusha.home.net> References: <201011120641.oAC6fui3098584@svn.freebsd.org> <8662w17e90.fsf@kopusha.home.net> <4CDF3A58.6080505@freebsd.org> <86pqu8q6lb.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/15/10 02:15, Mikolaj Golub wrote: > > On Sun, 14 Nov 2010 12:24:40 +1100 Lawrence Stewart wrote: > > LS> On 11/13/10 20:40, Mikolaj Golub wrote: > >> > >> On Fri, 12 Nov 2010 06:41:56 +0000 (UTC) Lawrence Stewart wrote: > >> > >> LS> Author: lstewart > >> LS> Date: Fri Nov 12 06:41:55 2010 > >> LS> New Revision: 215166 > >> LS> URL: http://svn.freebsd.org/changeset/base/215166 > >> > >> LS> Log: > >> LS> This commit marks the first formal contribution of the "Five New TCP Congestion > >> LS> Control Algorithms for FreeBSD" FreeBSD Foundation funded project. More details > >> LS> about the project are available at: http://caia.swin.edu.au/freebsd/5cc/ > >> > >> It looks like the code needs improvement to work with VIMAGE :-) > >> > >> options VIMAGE > >> > >> jail -i -c vnet persist path=/ > >> > >> panic: lock "cc_list" 0xc101c418 already initialized > >> [snip backtrace] > > LS> Would you mind testing the following patch? It fixes the panic for me. > > LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnetpanic_ccinit.patch > > With this patch the system hangs during the boot. Ctr-Alt-Esc to break into > ddb does not work. I am trying this under VirtualBox. I can't reproduce a hang, but please try this patch instead: http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnetpanic_ccinit_v2.patch The previous patch had a bug, in that CC modules register with SI_ORDER_ANY in the same SI_SUB_PROTO_IFATTACHDOMAIN category as the CC framework's SYSINIT (which also ran with SI_ORDER_ANY). Therefore, there is a possibility an algo could have tried to register before the CC framework SYSINIT ran. To be honest though, I don't expect the updated patch will fix the hang. I would have expected a panic rather than a hang if you were seeing any complications due to the SYSINIT ordering because the algo registration would have attempted to use an uninitialised lock. I suspect your hang might be caused by something unrelated to the modular CC work, but let me know how you go. Cheers, Lawrence
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CE08BB6.1090304>