From owner-freebsd-hackers Wed Oct 8 14:37:43 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id OAA16233 for hackers-outgoing; Wed, 8 Oct 1997 14:37:43 -0700 (PDT) (envelope-from owner-freebsd-hackers) Received: from tnt.isi.edu (tnt.isi.edu [128.9.128.128]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id OAA16213; Wed, 8 Oct 1997 14:37:35 -0700 (PDT) (envelope-from faber@ISI.EDU) Received: from ISI.EDU (vex-s.isi.edu [128.9.192.240]) by tnt.isi.edu (8.8.7/8.8.6) with ESMTP id OAA21262; Wed, 8 Oct 1997 14:37:34 -0700 (PDT) Message-Id: <199710082137.OAA21262@tnt.isi.edu> To: Stefan Esser Cc: freebsd-hackers@freebsd.org Subject: Re: patch for PCMCIA support on Hitachi Mx133 In-Reply-To: Your message of "Wed, 08 Oct 1997 22:09:36 +0200." <19971008220936.20316@mi.uni-koeln.de> X-Url: http://www.isi.edu/~faber Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 08 Oct 1997 14:37:34 -0700 From: Ted Faber Sender: owner-freebsd-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk -----BEGIN PGP SIGNED MESSAGE----- Stefan Esser wrote: >Ted Faber (wrongly) suggested: >> #define PCI_MAP_REG_START 0x10 >> ! #define PCI_MAP_REG_END 0x28 >> --- 139,145 ---- >> #define PCI_MAP_REG_START 0x10 >> ! #define PCI_MAP_REG_END 0x3f > >NO PLEASE DON'T ! > >This change will break the PCI code (in certain situations) !!! I've now seen the most recent PAO patch which supports the card without changing this file. I think it's a much better plan to use the PAO patch than mine. You shouldn't spend any more time looking at it, and my patch certainly should not be integrated. Thanks for pointing this potential big problem out. - ---------------------------------------------------------------------- Ted Faber faber@isi.edu USC/ISI Computer Scientist http://www.isi.edu/~faber (310) 822-1511 x190 PGP Key: http://www.isi.edu/~faber/pubkey.asc -----BEGIN PGP SIGNATURE----- Version: 2.6.2 iQCVAwUBNDv9HYb4eisfQ5rpAQE9+wQAtWhgegjxf1hzkglUqjAePEipiE6zPv8O 5eHkFLFSw4br5rZLHvtQ10sSXHCyYJmKCpIwclDTwqbHhyKmlzUZXb4hx773Et3s GT/VrroKO4+Y4UNEwu+8XE6FDp7FIejLwRurRlaxT7kOpaDizJ+uJgvi7ZOXFwhu sts7WnqNDDE= =7Gib -----END PGP SIGNATURE-----