From owner-p4-projects@FreeBSD.ORG  Wed Jan  7 15:13:04 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D87201065672; Wed,  7 Jan 2009 15:13:03 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 93F08106564A
	for <perforce@FreeBSD.org>; Wed,  7 Jan 2009 15:13:03 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 81F408FC1A
	for <perforce@FreeBSD.org>; Wed,  7 Jan 2009 15:13:03 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n07FD3dY019129
	for <perforce@FreeBSD.org>; Wed, 7 Jan 2009 15:13:03 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n07FD3Do019127
	for perforce@freebsd.org; Wed, 7 Jan 2009 15:13:03 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Wed, 7 Jan 2009 15:13:03 GMT
Message-Id: <200901071513.n07FD3Do019127@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 155759 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jan 2009 15:13:05 -0000

http://perforce.freebsd.org/chv.cgi?CH=155759

Change 155759 by hselasky@hselasky_laptop001 on 2009/01/07 15:12:24

	
	Optimise: Remove extra flush calls.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb2/controller/ohci2.c#22 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb2/controller/ohci2.c#22 (text+ko) ====

@@ -1558,13 +1558,12 @@
 	}
 	ed->ed_flags = htole32(ed_flags);
 
-	usb2_pc_cpu_flush(ed->page_cache);
-
 	td = xfer->td_transfer_first;
 
 	ed->ed_headp = td->td_self;
 
 	if (xfer->udev->pwr_save.suspended == 0) {
+		/* the append function will flush the endpoint descriptor */
 		OHCI_APPEND_QH(ed, *ed_last);
 
 		if (methods == &ohci_device_bulk_methods) {
@@ -2009,13 +2008,12 @@
 	}
 	ed->ed_flags = htole32(ed_flags);
 
-	usb2_pc_cpu_flush(ed->page_cache);
-
 	td = xfer->td_transfer_first;
 
 	ed->ed_headp = td->itd_self;
 
 	/* isochronous transfers are not affected by suspend / resume */
+	/* the append function will flush the endpoint descriptor */
 
 	OHCI_APPEND_QH(ed, sc->sc_isoc_p_last);
 }