From nobody Wed Feb 25 17:52:00 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fLhxV28gDz6TNgT for ; Wed, 25 Feb 2026 17:52:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fLhxT5JXFz3hLQ for ; Wed, 25 Feb 2026 17:52:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b="D/X4YgCo"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::42e as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-82735a41985so4556b3a.2 for ; Wed, 25 Feb 2026 09:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772041933; x=1772646733; darn=freebsd.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EDjzfVLRUKa7ZYPnLyAVv6qvrrORjygse1rce365qxo=; b=D/X4YgCodDvmLuuvm9hlycWXWF+E9jVTq32NS1v3CfhQb6dUKBjU34ZrVBXaIPEMpw XTTqYxsDAC8+oHcnTcYBamSGlmeXAqhSM460D70Xe7QZs4m39e6gka76gv6ORIA5hTca psESohEZFzVq/McL1Vc+fLxWUTuP85D2Xe20eGJb9wZS35AbvxKLp8dU6WTTBC/DKO6c 60Db5L7MsDhNvpbXpp4KH23UM7mPbbITwc8fsWRaq0RMB5FHKUSE+anLmHjFms6tVMbW dt1lJH7eIO4QhlJ/V8o+h/uXjcK+79167dsguPCB4XvOCgLAk1CvBpVWnzljmxMzPKfI bpIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772041933; x=1772646733; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EDjzfVLRUKa7ZYPnLyAVv6qvrrORjygse1rce365qxo=; b=Lsyxsgiu4UQSokkwMy7YhNzYy7cpnNDmWpucQ1ugpvFM5vsiBLo6AYVuB4FDS3sdND hvS/TWA48kDoeZttAiKaCeqE1vUI+Qi6pz4JOziotSXk7udbt0elVLnzeBzk1RtypLJ+ inFWdTU68K95Z/7/TiuGRxkgW4dHBjRz66oDgpH/w+Jc9fAe4uxN5+Ri55lgWopY8qJH 43UVZGvrnzrTDsFRit7K/Q16Xd+FpMxAcJ1zXngx7lBs4ASXyaNelvB5ogBVTp7TuLnL h1OmgNv03Y9m/F362rPbxxK4NUqjWOJeE2JClbhkfP4iOYCbijHY3fjKADztb0qmmt7/ MMFg== X-Forwarded-Encrypted: i=1; AJvYcCV9f2eWgxIAT93taPdH5ljG//CWafIVJMeflNiGCmN81J7bmiAEIf6Ijkcj9uNoCK9i8neYo4YQs8FvO9kIa14jJCPUEQ==@freebsd.org X-Gm-Message-State: AOJu0YzKEx0GUQnp1IS/5e+VSGve6j0F3tvu3puGG+i/SjGik0NZ2Wj3 wHWw23mksDTvnzA2mcIBuHZWu2DM/bjDxE31InwIAm1zCmSdsipqXM+e X-Gm-Gg: ATEYQzwowmtMfhRg+sIkyy8GoRsc+HUuXNyXkiTc5h4a2PtVZsieQiE3ZYpKUsOOwUv Zq4XaLeZyM7k2tYbad+0PIhZbHGOX3Mm81W7gcn7ANnnUsDwYuC3FO2oHQnE1nQc6LDzSZruYEn j0jOgjMeBt3//gsdhwt1JARaLhEzozTE7uTQJhkBWxw8lr4ASQMKchhLOdJWgDUGZL8ssMEp+u8 2ujqpLe4253dcUMw4CAgb4/PCGs+rw4q/GR27qnur17ksn5YgKj47PJt80VzkKHZ6eMDGpaiwdl kmmGGTyB8AlntdcYc8OMUqxewiet20W2mariyLmJ6PpWEN5bL8h/DOiB2pOrLsrGM69cb9HgccL 3HISyT5CeGngk02sNK7qzRlPLzOa96g1HGNofu3RhNRlY98NmeSTe7XUvepkdh+kkeIKtBtLAEc MGK9H/irD8g6fAGic0g32+TdJkm+OgIT9LluCQMJCi X-Received: by 2002:a05:6a00:895:b0:81b:bc05:e27d with SMTP id d2e1a72fcca58-8273375f52fmr1088940b3a.40.1772041932655; Wed, 25 Feb 2026 09:52:12 -0800 (PST) Received: from smtpclient.apple ([162.118.1.182]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd8ecc83sm14245700b3a.62.2026.02.25.09.52.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2026 09:52:12 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: git: 64dab63f3b3b - main - LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO From: "Enji Cooper (yaneurabeya)" In-Reply-To: <202201101950.20AJor0m009372@gitrepo.freebsd.org> Date: Wed, 25 Feb 2026 09:52:00 -0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <241DCDC1-B8A5-43CF-9FAA-19406EB8A996@gmail.com> References: <202201101950.20AJor0m009372@gitrepo.freebsd.org> To: Vladimir Kondratyev X-Mailer: Apple Mail (2.3826.700.81.1.4) X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::42e:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4fLhxT5JXFz3hLQ X-Spamd-Bar: --- > On Jan 10, 2022, at 11:50=E2=80=AFAM, Vladimir Kondratyev = wrote: >=20 > The branch main has been updated by wulf: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D64dab63f3b3b6c6a1f8a92f43bed0aa2= 8319d627 >=20 > commit 64dab63f3b3b6c6a1f8a92f43bed0aa28319d627 > Author: Vladimir Kondratyev > AuthorDate: 2021-12-25 18:42:15 +0000 > Commit: Vladimir Kondratyev > CommitDate: 2022-01-10 19:49:38 +0000 >=20 > LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO >=20 > compile time assertion on non-NULL pointers. Tests conducted show = that > _Static_assert, negative array size method and current code does = not > handle pointers well enough. Bit field method solves this problem. >=20 > This change is derrived from Linux implementation of = BUILD_BUG_ON_ZERO. >=20 > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D33674 > --- > sys/compat/linuxkpi/common/include/linux/kernel.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/sys/compat/linuxkpi/common/include/linux/kernel.h = b/sys/compat/linuxkpi/common/include/linux/kernel.h > index 419dae214396..a84f577dd912 100644 > --- a/sys/compat/linuxkpi/common/include/linux/kernel.h > +++ b/sys/compat/linuxkpi/common/include/linux/kernel.h > @@ -109,9 +109,7 @@ > #define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x) > #define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x)) > #define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); } > - > -extern const volatile int lkpi_build_bug_on_zero; > -#define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0) > +#define BUILD_BUG_ON_ZERO(x) ((int)sizeof(struct { int:-((x) !=3D 0); = })) Hi Vladimir, I think this change is causing build problems now with gcc14. = Please see the snippet from = https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/2986/consoleText= below. Thanks, -Enji --- all_subdir_rtw89 --- --- core.o --- In file included from = /workspace/src/sys/compat/linuxkpi/common/include/linux/kernel.h:44, from = /workspace/src/sys/compat/linuxkpi/common/include/linux/skbuff.h:39, from = /workspace/src/sys/compat/linuxkpi/common/include/linux/ip.h:40, from /workspace/src/sys/contrib/dev/rtw89/core.c:9: /workspace/src/sys/contrib/dev/rtw89/core.c: In function = 'rtw89_bcn_calc_drift': = /workspace/src/sys/compat/linuxkpi/common/include/linux/build_bug.h:60:33:= error: statement with no effect [-Werror=3Dunused-value] 60 | #define BUILD_BUG_ON_ZERO(x) ((int)sizeof(struct { int:-((x) = !=3D 0); })) | ^ /workspace/src/sys/compat/linuxkpi/common/include/linux/sort.h:37:9: = note: in expansion of macro 'BUILD_BUG_ON_ZERO' 37 | BUILD_BUG_ON_ZERO(swap); \ | ^~~~~~~~~~~~~~~~~ /workspace/src/sys/contrib/dev/rtw89/core.c:2575:9: note: in expansion = of macro 'sort' 2575 | sort(drift, RTW89_BCN_TRACK_STAT_NR, sizeof(*drift), = cmp_u16, NULL); | ^~~~=