Date: Fri, 7 Jan 2011 17:02:12 +0300 From: Eygene Ryabinkin <rea@freebsd.org> To: Anton Shterenlikht <mexas@bristol.ac.uk> Cc: Anonymous <swell.k@gmail.com>, riggs@rrr.de, freebsd-ports@freebsd.org Subject: Re: mplayer options patch Message-ID: <T91oGvU/CUCYTUdRQP14BhcxeOw@5UW8B3LwPEGInFShts5A7R/S2Yo> In-Reply-To: <20110107133239.GA99670@mech-cluster241.men.bris.ac.uk> References: <20110107095816.GA64948@mech-cluster241.men.bris.ac.uk> <MKws6xL2clvIhh8rR9KC/WtQ8GE@QsmfhJNucgI88DfvPJdT1/nyboE> <86lj2xhrfi.fsf@gmail.com> <20110107114923.GA70063@mech-cluster241.men.bris.ac.uk> <86wrmghqjc.fsf@gmail.com> <20110107120900.GA70442@mech-cluster241.men.bris.ac.uk> <8662u0hp8j.fsf@gmail.com> <20110107133239.GA99670@mech-cluster241.men.bris.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--Do4IU1xF/9sod/r6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Fri, Jan 07, 2011 at 01:32:39PM +0000, Anton Shterenlikht wrote:
> I don't think I need to change any other options from=20
> the current default to make it build and run on my ia64.
>=20
> So if this patch seems reasonable, can somebody submit it?
>=20
> many thanks
> anton
>=20
>=20
> --- Makefile 2010-12-02 09:18:00.000000000 +0000
> +++ Makefile.new 2011-01-07 11:16:56.000000000 +0000
> @@ -13,7 +13,6 @@
> .include "${.CURDIR}/Makefile.shared"
> =20
> OPTIONS=3D DEBUG "Include debug symbols in mplayer's binaries" off
> -OPTIONS+=3D RTCPU "Allow runtime CPU detection" on
> OPTIONS+=3D OCFLAGS "Use optimized compiler flags" on
> OPTIONS+=3D IPV6 "Include inet6 network support" on
> OPTIONS+=3D X11 "Enable X11 support for mplayer's video output" on
> @@ -75,6 +74,12 @@
> BROKEN=3D Does not compile on sparc64
> .endif
> =20
> +.if ${ARCH} =3D=3D "i386" || ${ARCH} =3D=3D "amd64" || ${ARCH} =3D=3D "p=
owerpc"
> +OPTIONS+=3D RTCPU "Allow runtime CPU detection" on
> +.else
> +OPTIONS+=3D RTCPU "Allow runtime CPU detection" off
> +.endif
Having thinked about it for a while, I wonder if we need to have
RTCPU knob on non-{i386,amd64,powerpc}? From the one hand, the
knob isn't functional, so it is redundant, because mplayer will
refuse to build. On the other hand, once mplayer will gain the
ability to make run-time CPU detection on other platforms, this
knob will be usable again and it will be good to add it to the
relevant architectures.
I think that this should be left to the maintainers decision.
Please, submit a PR that describes the problem and contains
the patch. If submitting PR is something you hadn't done before,
please, take a look at
http://www.freebsd.org/doc/en_US.ISO8859-1/articles/problem-reports/artic=
le.html
You can add me to the X-GNATS-Notify header -- I'll take the PR
and once/if Thomas will approve it, I'll commit the modifications.
--=20
Eygene Ryabinkin ,,,^..^,,,
[ Life's unfair - but root password helps! | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
--Do4IU1xF/9sod/r6
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)
iF4EAREIAAYFAk0nHOMACgkQFq+eroFS7PvXyQD/Uc3hUGL6cdtVxTColPr+g0gm
nzrdlHkY0aYHe9L/JecA/1SOcuJTga+z6kn5YUrlMj2FG33SMXXNLQ9FBBYAvGi2
=rzN/
-----END PGP SIGNATURE-----
--Do4IU1xF/9sod/r6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?T91oGvU/CUCYTUdRQP14BhcxeOw>