From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 4 02:31:38 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFE6B16A4CE; Fri, 4 Jun 2004 02:31:38 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1A9B43D3F; Fri, 4 Jun 2004 02:31:38 -0700 (PDT) (envelope-from das@FreeBSD.org) Received: from freefall.freebsd.org (das@localhost [127.0.0.1]) i549VVri031958; Fri, 4 Jun 2004 02:31:31 -0700 (PDT) (envelope-from das@freefall.freebsd.org) Received: (from das@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i549VV4g031954; Fri, 4 Jun 2004 02:31:31 -0700 (PDT) (envelope-from das) Date: Fri, 4 Jun 2004 02:31:31 -0700 (PDT) From: David Schultz Message-Id: <200406040931.i549VV4g031954@freefall.freebsd.org> To: dga@lcs.mit.edu, das@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/67467: df -m and -g incorrect with negative avail X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2004 09:31:39 -0000 Synopsis: df -m and -g incorrect with negative avail State-Changed-From-To: open->closed State-Changed-By: das State-Changed-When: Fri Jun 4 02:30:57 PDT 2004 State-Changed-Why: Thanks for the analysis. It turns out that this problem was fixed last month in src/bin/df/df.c,v 1.56 using your first proposal. However, in reviewing the code, I found that I was able to save 775 bytes and a small piece of my sanity by making fsbtoblk() a true function. This should address your concern about the ambiguity in the type of num. (As for gcc extensions, we use them in some places, but we try not to depend on them when possible.) http://www.freebsd.org/cgi/query-pr.cgi?pr=67467