From owner-freebsd-current@FreeBSD.ORG  Fri Jan  3 00:22:29 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C227B21D;
 Fri,  3 Jan 2014 00:22:29 +0000 (UTC)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8E41612B2;
 Fri,  3 Jan 2014 00:22:29 +0000 (UTC)
Received: from [192.168.1.73] (254C510A.nat.pool.telekom.hu [37.76.81.10])
 (authenticated bits=0)
 by vps1.elischer.org (8.14.7/8.14.7) with ESMTP id s030MELl019270
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Thu, 2 Jan 2014 16:22:16 -0800 (PST)
 (envelope-from julian@freebsd.org)
Message-ID: <52C602B0.7060904@freebsd.org>
Date: Fri, 03 Jan 2014 01:22:08 +0100
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Roger Pau Monne <roger.pau@citrix.com>, freebsd-xen@freebsd.org,
 freebsd-current@freebsd.org, xen-devel@lists.xen.org,
 gibbs@freebsd.org, jhb@freebsd.org, kib@freebsd.org,
 julien.grall@citrix.com
Subject: Re: [PATCH v9 19/19] isa: allow ISA bus to attach to xenpv device
References: <1388677433-49525-1-git-send-email-roger.pau@citrix.com>
 <1388677433-49525-20-git-send-email-roger.pau@citrix.com>
In-Reply-To: <1388677433-49525-20-git-send-email-roger.pau@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jan 2014 00:22:29 -0000

On 1/2/14, 4:43 PM, Roger Pau Monne wrote:
> ---
>   sys/x86/isa/isa.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sys/x86/isa/isa.c b/sys/x86/isa/isa.c
> index 1a57137..9287ff2 100644
> --- a/sys/x86/isa/isa.c
> +++ b/sys/x86/isa/isa.c
> @@ -241,3 +241,6 @@ isa_release_resource(device_t bus, device_t child, int type, int rid,
>    * On this platform, isa can also attach to the legacy bus.
>    */
>   DRIVER_MODULE(isa, legacy, isa_driver, isa_devclass, 0, 0);
> +#ifdef XENHVM
> +DRIVER_MODULE(isa, xenpv, isa_driver, isa_devclass, 0, 0);
> +#endif
read all 19 patches. I'm glad you split them up.. makes it 
understandable.. even by me :-)
no real negative comments except a question as to whether there is any 
noticable performance impact on real hardware?