Date: Tue, 8 May 2001 15:56:38 -0500 From: Will Andrews <will@physics.purdue.edu> To: Mikhail Teterin <mi@misha.privatelabs.com> Cc: ports@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: port policies Message-ID: <20010508155638.C8870@casimir.physics.purdue.edu> In-Reply-To: <200105082029.f48KTtC38076@misha.privatelabs.com>; from mi@misha.privatelabs.com on Tue, May 08, 2001 at 04:29:54PM -0400 References: <20010508122714.B48723@FreeBSD.org> <200105082029.f48KTtC38076@misha.privatelabs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline [ moved to ports@ ] On Tue, May 08, 2001 at 04:29:54PM -0400, Mikhail Teterin wrote: > The user did not ask for ``-O -pipe'' in the CFLAGS either. -pipe, > consumes more memory, while -O makes compiling longer. Should the > default CFLAGS be empty too? By your logic, they should... -O -pipe is known to work in many many more cases than -jN, because the latter is much more dependent on how well people architect their code. Anyway, there's no chance in hell I'm going to let the default add -jN. Please stop trying. Be happy that you can set them in make.conf. I think the attached patch will do. portmgr@, any objections to testing it on bento (seems to work fine here)? -- wca --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="bsd.port.mk.jobs.diff" --- bsd.port.mk Tue Apr 24 13:34:25 2001 +++ bsd.port.mk.new Tue May 8 15:42:37 2001 @@ -404,6 +404,9 @@ # and install stages (default: see below). # MAKE_ARGS - Any extra arguments to sub-make in build and install # stages (default: none). +# MAKE_JOBS - Specify the -jN option to be added to MAKE_ARGS when +# PARALLEL_SAFE is defined (default: none). +# PARALLEL_SAFE - Says that the port is safe to build with ${MAKE} -jN. # # For install: # @@ -742,6 +745,12 @@ PLIST_SUB+= PORTDOCS="@comment " .else PLIST_SUB+= PORTDOCS="" +.endif + +MAKE_JOBS?= 1 + +.if defined(PARALLEL_SAFE) && ${MAKE_JOBS} > 1 +MAKE_ARGS+= -j${MAKE_JOBS} .endif CONFIGURE_ENV+= PORTOBJFORMAT=${PORTOBJFORMAT} --cWoXeonUoKmBZSoM-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010508155638.C8870>