From owner-freebsd-hackers  Thu Aug 13 17:24:24 1998
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id RAA16924
          for freebsd-hackers-outgoing; Thu, 13 Aug 1998 17:24:24 -0700 (PDT)
          (envelope-from owner-freebsd-hackers@FreeBSD.ORG)
Received: from implode.root.com (implode.root.com [198.145.90.17])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA16897;
          Thu, 13 Aug 1998 17:24:20 -0700 (PDT)
          (envelope-from root@implode.root.com)
Received: from implode.root.com (localhost [127.0.0.1])
	by implode.root.com (8.8.5/8.8.5) with ESMTP id RAA17790;
	Thu, 13 Aug 1998 17:23:38 -0700 (PDT)
Message-Id: <199808140023.RAA17790@implode.root.com>
To: Mike Smith <mike@smith.net.au>
cc: peter@sirius.com, mrcpu@internetcds.com (Jaye Mathisen),
        hackers@FreeBSD.ORG, stable@FreeBSD.ORG
Subject: Re: vmopar state in 2.2.7? 
In-reply-to: Your message of "Thu, 13 Aug 1998 12:59:45 PDT."
             <199808131959.MAA00604@dingo.cdrom.com> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Thu, 13 Aug 1998 17:23:38 -0700
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

>> Try changing lines 1226 and 1261 to something like:
>> 	tsleep(p, PVM, "vmopar", 5 * hz);
>...
>> This function would return "EWOULDBLOCK" after the time-out expires then, 
>> no clue what that will do to your system or apps ;) -- I would expect the
>> blocked process to go away within 5 seconds...
>
>I dont' have 2.2 sources to hand, and the above is now just a call to 
>vm_page_sleep, but if the timeout expires, the entire operation is 
>retried, so it should be harmless (although it is masking a legitimate 
>bug).

   I said in my last reply on this that it would do bad things, but you're
probably right that it should be harmless. There are other parts of the code
where premature wakeups would be bad, so one must be careful about making
this assumption.
   If that "fixes" the problem, then this probably indicates a problem with
a missing wakeup somewhere.

-DG

David Greenman
Co-founder/Principal Architect, The FreeBSD Project

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message