From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 16 08:20:33 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 946C616A5A4
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 16 Feb 2005 08:20:33 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7865C43D4C
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 16 Feb 2005 08:20:33 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1G8KX1X081433
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 16 Feb 2005 08:20:33 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1G8KXQ0081432;
	Wed, 16 Feb 2005 08:20:33 GMT
	(envelope-from gnats)
Date: Wed, 16 Feb 2005 08:20:33 GMT
Message-Id: <200502160820.j1G8KXQ0081432@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Maxim Konovalov <maxim@macomnet.ru>
Subject: Re: kern/77570: [PATCH] ipfw: Multiple rules may have the same
 number.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Maxim Konovalov <maxim@macomnet.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Feb 2005 08:20:33 -0000

The following reply was made to PR kern/77570; it has been noted by GNATS.

From: Maxim Konovalov <maxim@macomnet.ru>
To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
Cc: bug-followup@freebsd.org
Subject: Re: kern/77570: [PATCH] ipfw: Multiple rules may have the same
 number.
Date: Wed, 16 Feb 2005 11:17:34 +0300 (MSK)

 Hi Wojciech,
 
 > >Description:
 > There is a problem while inserting ipfw2 rule with specified rule number.
 >
 > 	# ipfw add <num> <action>
 >
 > While executing this command N times, it will add N rules with the same
 > number <num>. I don't really like this behaviour, since rule number has to
 > represent the unique rule.
 >
 > >How-To-Repeat:
 >
 > This problem may be easily reproduced:
 >
 > # ipfw add 100 allow all from any to any
 > 00100 allow ip from any to any
 > # ipfw add 100 allow all from any to any
 > 00100 allow ip from any to any
 > # ipfw add 100 allow all from any to any
 > 00100 allow ip from any to any
 > # ipfw show | grep 00100
 > 00100 0   0 allow ip from any to any
 > 00100 0   0 allow ip from any to any
 > 00100 0   0 allow ip from any to any
 >
 > >Fix:
 > Attached patch [diff.0.ipfw2] should correct this problem. It also adds predefinition of
 > remove_rule(), because after applying this patch, add_rule() requires it.
 
 Well, sorry, I really hate your patch :-)  This is the way ipfw(8) was
 designed and works in RELENG_*.  It seems for me we gonna break
 zillion ipfw installations with this patch.  "Tools not policy".
 
 Would you mind if I close this PR?
 
 -- 
 Maxim Konovalov