From owner-freebsd-stable@FreeBSD.ORG Fri Feb 1 17:53:05 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 5E72499B; Fri, 1 Feb 2013 17:53:05 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id E818C618; Fri, 1 Feb 2013 17:53:03 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.5/8.14.5) with ESMTP id r11Hr47t006831; Fri, 1 Feb 2013 11:53:04 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.5/8.14.5/Submit) id r11Hr3lT006830; Fri, 1 Feb 2013 11:53:03 -0600 (CST) (envelope-from brooks) Date: Fri, 1 Feb 2013 11:53:03 -0600 From: Brooks Davis To: Mark Linimon Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 Message-ID: <20130201175303.GA5914@lor.one-eyed-alien.net> References: <50F6D20A.6070306@FreeBSD.org> <20130117151502.GF29437@lor.one-eyed-alien.net> <20130201042244.GC20772@lonesome.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: <20130201042244.GC20772@lonesome.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Kimmo Paasiala , Brooks Davis , freebsd-stable@freebsd.org, Dimitry Andric X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2013 17:53:05 -0000 --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 31, 2013 at 10:22:44PM -0600, Mark Linimon wrote: > On Thu, Jan 17, 2013 at 09:15:02AM -0600, Brooks Davis wrote: > > Not unless you consider adding new functions in a reserved namespace > > (str*) to be ABI breakage. >=20 > Well, what often happens is that when we add new functions, ports break. > I think deciding whether this is or is not "ABI breakage" is semantics. > The fact is that regressions get introduced with these types of changes. >=20 > > The port should have continued to work unless it was recompiled so it > > should have preferred it's own version of the strnvis symbol. If its > > makefiles were properly constructed it would have failed to compile > > due to the signature mismatch. >=20 > The mantra should be "every possible combination of ways that a port's > internal build glue can be wrong, is already included in the Ports Collec= tion." > In case after case we see fragile code that is written by people who are > clearly not professionally trained. They "get it to work on their system" > and then shove it out the door. >=20 > Claiming that "they shouldn't do that" is correct but self-defeating. > It's just the reality of open-source software. I'm not sure why I'm being jumped on me in this weeks old report of a now-fixed problem. I did determine to root cause and others produced a patch. If no one else had stepped up I would have done so my self. > IMHO, the burden should be on whoever makes the change to find out whether > or not regressions will be introduced. (And yes, I am very aware that we > don't have -exp run capability right now, but this is one of the cases > where I would like to suggest it would have helped.) I would likely have done an exp run had there been the capability of doing one, but this bug would not have been found since it's a runtime crash caused by a combination of two different BSD projects not talking to each other and poorly chosen CFLAGS in the upstream software allowing it to compile. One could probably write a tool to detect some forms this sort of issue (even premptively), but it's probably not worth doing. -- Brooks --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFRDAD/XY6L6fI4GtQRAgllAJ9dWqbKtUsVMUjayOIe3joOoem+SACfQUjF hM3JRL77y9So4+154fcJn30= =r26r -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--