From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 12 19:20:07 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACB9216A41C for ; Tue, 12 Jul 2005 19:20:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2E3143D5F for ; Tue, 12 Jul 2005 19:20:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j6CJK5Ne075781 for ; Tue, 12 Jul 2005 19:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j6CJK5SF075778; Tue, 12 Jul 2005 19:20:05 GMT (envelope-from gnats) Resent-Date: Tue, 12 Jul 2005 19:20:05 GMT Resent-Message-Id: <200507121920.j6CJK5SF075778@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90A7F16A41C for ; Tue, 12 Jul 2005 19:19:01 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id C60C243D48 for ; Tue, 12 Jul 2005 19:18:57 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.3/8.13.3) with ESMTP id j6CJItLR016653 for ; Tue, 12 Jul 2005 21:18:56 +0200 (CEST) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.3/8.13.1/Submit) id j6CJItCe016652; Tue, 12 Jul 2005 21:18:55 +0200 (CEST) (envelope-from dan) Message-Id: <200507121918.j6CJItCe016652@kulesh.obluda.cz> Date: Tue, 12 Jul 2005 21:18:55 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/83347: [ PATCH ] improper handling of malloc failures within libc's vfprintf X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2005 19:20:07 -0000 >Number: 83347 >Category: bin >Synopsis: [ PATCH ] improper handling of malloc failures within libc's vfprintf >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 12 19:20:05 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.4-STABLE i386 >Organization: Obludarium >Environment: System: FreeBSD 5.4-STABLE #8: Sat Jul 9 16:31:08 CEST 2005 i386 lib/libc/stdio/vfprintf.c,v 1.67.2.1 2004/08/31 05:20:43 des >Description: Improper handling of malloc failures within __find_arguments() - the supporting function for vfprintf() - can cause dereferencing of NULL >How-To-Repeat: >Fix: The abort() is not the best way to handle this kind of failure, but it's the same way as other function within the same source, the __grow_type_table() handle it. abort() seems to be better than nothink. --- patch begins here --- --- lib/libc/stdio/vfprintf.c.ORIG Tue Aug 31 07:20:43 2004 +++ lib/libc/stdio/vfprintf.c Tue Jul 12 21:11:09 2005 @@ -1486,6 +1486,8 @@ if (tablemax >= STATIC_ARG_TBL_SIZE) { *argtable = (union arg *) malloc (sizeof (union arg) * (tablemax + 1)); + if (*argtable == NULL) + abort(); /* XXX handle better */ } (*argtable) [0].intarg = 0; --- patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: