From owner-freebsd-bugs Thu May 25 22:52:52 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from ns.itga.com.au (ns.itga.com.au [202.53.40.210]) by hub.freebsd.org (Postfix) with ESMTP id 44E7437B581 for ; Thu, 25 May 2000 22:52:46 -0700 (PDT) (envelope-from gnb@itga.com.au) Received: from lightning.itga.com.au (lightning.itga.com.au [192.168.71.20]) by ns.itga.com.au (8.9.3/8.9.3) with ESMTP id PAA87293; Fri, 26 May 2000 15:52:37 +1000 (EST) (envelope-from gnb@itga.com.au) Received: from itga.com.au (lightning.itga.com.au [192.168.71.20]) by lightning.itga.com.au (8.9.3/8.9.3) with ESMTP id PAA20510; Fri, 26 May 2000 15:52:35 +1000 (EST) Message-Id: <200005260552.PAA20510@lightning.itga.com.au> X-Mailer: exmh version 2.0.1 12/23/97 From: Gregory Bond To: yab@astem.or.jp Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/18526: mx does not receive ethernet broadcast packet In-reply-to: Your message of Thu, 25 May 2000 03:20:03 -0700. Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 26 May 2000 15:52:35 +1000 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > + if (t->mx_did == MX_DEVICEID_987x5) > + if (rev != MX_REVISION_98715AEC) > + t++; > + else if (rev >= MX_REVISION_98725) > + t++; Either I'm dense or this is not right (or at the very least, wildly redundant). if (rev != a) t++; else if (rev >= b) t++; makes no sense when a & b are constant. Mind you, I've got no idea about what this code actually does, so I've no idea what the author was intending...... but I doubt the above code expresses that intention correctly. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message