From owner-svn-src-all@freebsd.org Tue Dec 5 04:40:49 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34A4DDF3CCC; Tue, 5 Dec 2017 04:40:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f45.google.com (mail-it0-f45.google.com [209.85.214.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A3B106A02A; Tue, 5 Dec 2017 04:40:48 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f45.google.com with SMTP id f143so12222352itb.0; Mon, 04 Dec 2017 20:40:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=6uVLrb91Oeemamd1UMP4OYX8iuJ5Vna+YgZJVrlyKuk=; b=sO14cKM/dXwYqzpmoK9zauIg7mpl4buhI3aY5Jv2HzlIGlOYQGLEfkhyb47V8DRZmo V8mgj832KQFqA7V9T2fEYy5/t/iB1XV5ETa832vn+f6JWUkuzmw7nN8+DXnRRqFVz7l6 5YgcJvNcwN2m+SiyLn/HWoQlHMnai3lSUuVjlKeF7kDpKoyTEsps5ijO8t4ZNLxHJuJ5 ib26XRj/vpuNDfJt3H3Dst9cfvWG9Llzcf7UEpn10C2vi83yhxE5xlA2mFUNPOg6WuI3 k0OjmZwLQXl85AbD8WkOWqifTSaLWklipiAi95KIFYec7/Q2Ns3RJpLcKl8S25mmFrHI onLw== X-Gm-Message-State: AKGB3mLlfaLGfctS6TcMSVr3Vm6AH9AMf1Iygu22b+mrMFxiil6LxKxo 3umNCtDVYHLWPRBawEYw3ts32bXn X-Google-Smtp-Source: AGs4zMZg8eC6btp2R4onGuwKpda0VdAmJErNqew/K4JhhzyHSQT2DpPMEbKhAyC0r8r/Y42QTj6hhA== X-Received: by 10.107.41.70 with SMTP id p67mr11761012iop.142.1512448847689; Mon, 04 Dec 2017 20:40:47 -0800 (PST) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com. [209.85.214.47]) by smtp.gmail.com with ESMTPSA id o137sm4802016ito.5.2017.12.04.20.40.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 20:40:47 -0800 (PST) Received: by mail-it0-f47.google.com with SMTP id x28so18392734ita.0; Mon, 04 Dec 2017 20:40:47 -0800 (PST) X-Received: by 10.36.192.2 with SMTP id u2mr16000769itf.119.1512448847457; Mon, 04 Dec 2017 20:40:47 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.165.150 with HTTP; Mon, 4 Dec 2017 20:40:47 -0800 (PST) In-Reply-To: References: <201712050355.vB53tApl074041@repo.freebsd.org> From: Conrad Meyer Date: Mon, 4 Dec 2017 20:40:47 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 04:40:49 -0000 On Mon, Dec 4, 2017 at 8:30 PM, Conrad Meyer wrote: > On Mon, Dec 4, 2017 at 7:55 PM, Eitan Adler wrote: >> Author: eadler >> Date: Tue Dec 5 03:55:10 2017 >> New Revision: 326554 >> URL: https://svnweb.freebsd.org/changeset/base/326554 >> >> Log: >> sponge(1): initial commit >> >> sponge(1) is a utility that reads input until >> complete, then opens the output file, then >> writes to it. This makes it useful in pipelines >> that read and write to the same file. >> >> Reviewed by: wblock, jilles, imp, cem, danfe (all: various iterations) > > I don't recall reviewing this in any iteration, but I could be mistaken. > > Best, > Conrad In fact I don't think any of the listed reviewers approved the change, at least in phabricator. The "Reviewed by" line signifies not just giving feedback, but approval of the final (or near-final) change. Best, Conrad