From owner-svn-src-all@freebsd.org Sun Mar 3 19:12:27 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E207215152E4 for ; Sun, 3 Mar 2019 19:12:26 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B14C88F37B for ; Sun, 3 Mar 2019 19:12:24 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-ed1-x52b.google.com with SMTP id g9so2482288eds.3 for ; Sun, 03 Mar 2019 11:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=d/tAVQpwLOJPN0y9NsV2K1F6e3/VXv2eQu1E+Jf1bpo=; b=wx904Uh8/5ey+2IY0HtYjlcHJdyg5VJnH87PlkR7thu5raAAyupmy/mpOPk6/njL+M LHpRGkop0xNNh+ImGP99b+y6WEVCcFOOC62MV8EwcpmrXUwZPFdvS0UECPiwMuwHash+ iNAgT4UARJxxpcRal6L5GeKjL/WtzWWa/XS2ZBn5P+cAvp4q1beLA1JEuIqf6dgFjr3D vg6vMf+LZ1G5sgEd0dHe5GGmRikOmPPUwHqMAwROoK6RIJAZzFQwbVeS9IqHLSOLdgib dj8SZ6DZ3xHgUI0Y+uRqxNs7FIR3RVKBkySXX+mOVY4vEBrhFDbgoeilDWYjWfGk+u7N 3OWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=d/tAVQpwLOJPN0y9NsV2K1F6e3/VXv2eQu1E+Jf1bpo=; b=L0TLPQ6zm/jZKzp4dKXptoGFJ4/dtgMVfBiyZjgFQPE2zUjh9+t4EET7IlYUZVBiFp 95q8mTf/Fz6l7TIAjIu16I7qLGVgglzEdCFbYaSvKZhK7e5PgrgKs643CLuXJZsMoyqk ffpQZ4nPgHgbM9sVUfnmFy/4qycAIJLIrK070Sudk5ooEcQYXvvI8IDaSZqx6TBFq+N2 /PVH6t74WDtSE/gTb/FVDKJgSd2wkY/IMZUl6kpweQyIuAjrGVPkGEQair77xcf17wXZ QtxEE7F7B6m/PfzBQlVeGn0jNA3R05wGgVktd8xXeS2x14slZcSu7GECNS1vk99B0g6Y OxtA== X-Gm-Message-State: APjAAAWJc36wwLhkgcJUlW0fqN39pKpZ8Sc0pg+SkV+45tGkojuaCcK5 w5DX2Vd8VmFX0k3LbnnRc/IiRg== X-Google-Smtp-Source: APXvYqyw6pPnetQwRspCd00/31wxlBMFyQkZ7p7NSlJfLniioStaL48TBH8FQqJqN95f2bRYqk9YUw== X-Received: by 2002:a05:6402:171a:: with SMTP id y26mr12842718edu.72.1551640343324; Sun, 03 Mar 2019 11:12:23 -0800 (PST) Received: from [10.44.128.75] ([161.12.40.153]) by smtp.gmail.com with ESMTPSA id y45sm1407472edd.33.2019.03.03.11.12.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Mar 2019 11:12:22 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r344701 - head/sbin/camcontrol To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201903011439.x21EdFlH055596@repo.freebsd.org> <20190302104909.GA25217@FreeBSD.org> Message-ID: Date: Sun, 3 Mar 2019 19:12:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190302104909.GA25217@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: B14C88F37B X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=multiplay-co-uk.20150623.gappssmtp.com header.s=20150623 header.b=wx904Uh8; spf=pass (mx1.freebsd.org: domain of steven@multiplay.co.uk designates 2a00:1450:4864:20::52b as permitted sender) smtp.mailfrom=steven@multiplay.co.uk X-Spamd-Result: default: False [-5.18 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[multiplay-co-uk.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[multiplay.co.uk]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_TO(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[multiplay-co-uk.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ASPMX.L.GOOGLE.COM]; RCVD_IN_DNSWL_NONE(0.00)[b.2.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; IP_SCORE(-2.68)[ip: (-9.02), ipnet: 2a00:1450::/32(-2.29), asn: 15169(-2.04), country: US(-0.07)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 19:12:27 -0000 Not really much more to say that isn't explained by that and the code. Sure I could have used a different sentence structure for the body but it wouldn't add anything IMO, thoughts? On 02/03/2019 10:49, Alexey Dokuchaev wrote: > On Fri, Mar 01, 2019 at 02:39:15PM +0000, Steven Hartland wrote: >> New Revision: 344701 >> URL: https://svnweb.freebsd.org/changeset/base/344701 >> >> Log: >> Fix incorrect / unused sector_count for identify requests >> >> Fix incorrect / unused sector_count for identify requests from camcontrol. >> >> Submitted by: Alexey Dokuchaev > Thanks, although commit message is a bit scarce. Also, for some reason, > it consists of two nearly identical lines -- unnoticed copy paste error? > > ./danfe