From owner-cvs-all@FreeBSD.ORG  Mon Apr 14 09:41:00 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2559C37B401; Mon, 14 Apr 2003 09:41:00 -0700 (PDT)
Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2D2B843F93; Mon, 14 Apr 2003 09:40:59 -0700 (PDT)
	(envelope-from mdodd@FreeBSD.ORG)
Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223])
	by sasami.jurai.net (8.12.9/8.12.9) with ESMTP id h3EGeuEF077345;
	Mon, 14 Apr 2003 12:40:56 -0400 (EDT)
	(envelope-from mdodd@FreeBSD.ORG)
Date: Mon, 14 Apr 2003 12:40:56 -0400 (EDT)
From: "Matthew N. Dodd" <mdodd@FreeBSD.ORG>
X-X-Sender: winter@sasami.jurai.net
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030414.102923.58074053.imp@bsdimp.com>
Message-ID: <20030414124016.O39446@sasami.jurai.net>
References: <200304140945.h3E9jPCe005099@repoman.freebsd.org>
 <20030414.102923.58074053.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: sobomax@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
cc: cvs-src@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2003 16:41:00 -0000

On Mon, 14 Apr 2003, M. Warner Losh wrote:
> In message: <200304140945.h3E9jPCe005099@repoman.freebsd.org>
>             Maxim Sobolev <sobomax@FreeBSD.org> writes:
> :   Before attaching device set PCIM_CMD_PORTEN in addition to
> :   PCIM_CMD_MEMEN and PCIM_CMD_BUSMASTEREN, becaise some braindead
> :   BIOSes (such as one found in my vprmatrix notebook) forget
> :   to initialize it properly resulting in attachment failure.
>
> Actually, code like this should be the pci bus, since all driver have
> this issue...

Likely this could be added to the bus_alloc_resource() path...  Doing a
sanity check on requests and then enabling the resource seems like the
correct solution.

-- 
| Matthew N. Dodd  | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD  |
| winter@jurai.net |       2 x '84 Volvo 245DL        | ix86,sparc,pmax |
| http://www.jurai.net/~winter |  For Great Justice!  | ISO8802.5 4ever |