From nobody Mon Oct 17 11:46:36 2022 X-Original-To: multimedia@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MrZvx08Zsz4ffmw for ; Mon, 17 Oct 2022 11:46:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MrZvw6FB7z3dWx for ; Mon, 17 Oct 2022 11:46:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MrZvw5KSZznqc for ; Mon, 17 Oct 2022 11:46:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29HBkatw061985 for ; Mon, 17 Oct 2022 11:46:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29HBka0p061984 for multimedia@FreeBSD.org; Mon, 17 Oct 2022 11:46:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 267100] graphics/gstreamer1-plugins-gl: fails to build if graphics/libdrm is installed Date: Mon, 17 Oct 2022 11:46:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jcfyecrayz@liamekaens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Multimedia discussions List-Archive: https://lists.freebsd.org/archives/freebsd-multimedia List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-multimedia@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666007196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MN1xC867ZFjADzY3CC5XZchToEWsGQZKbMJ7Wbx4Ziw=; b=YWOq3wChNvm21DDRKxi8H8ZTrN0NQWbdiQexPrmlpgS08YPTDEoUrL31jYv0A7jwpl7Qoy 4tXDA1juuQh4WeDewLYxE7Jn/ZlAu6dkLUNUMq9mp8c8ah9XyzEMU3iRNjYHmB0qYEl7yX qTaa6Mzo7GOFBhDpNJUgMQgnql5QG/pNeGCi9MAtqZz+YcLagPV39RdALaL6k4/PHm78KW GTgTBwKOzNQt9qYN70if/4XDGWeT5vRLxHgt1Tp4JK23ivS4oEtJfKbqUdDcWYKpUzky/l oMGhVVObq6FtnumDvxq0MUSx9WOtxn3P4EnFq+doMiPfluceayD/zoy2vx4EIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666007196; a=rsa-sha256; cv=none; b=R+5bqqVcdYBM/L/Hrs5CjegRQLcDzHgAwVm13m4cbJ/fsZvrueDzE4KyJAsBMnVM/rNA/D 1/gkPyiLYqzK5wXJgqiSwOcOoj8tTMOawcXYbSJw/TNhlkaNNoKw0R6KV+sivF+VOlk9Y1 7ib2dfanclUwW7exXBOQ/blDqHf19Z/ZFNGhFOheHOAwp+nSHWr3BunIvEcuPPLo7FyUyT d2eKzDfysZ1rlpi3N9UrKFu3aW4mJuXqUZLRdGE1pmAY0U04PBvoln4EDamISFmsKoQ7ui tViJwvSRR/Q5yvDz0Gv0T8i/UqPVeAY0/8My6HaaAWStyhnEjkBLxwlv0npvSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267100 John Hein changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcfyecrayz@liamekaens.com, | |michal.zielonka.8001@gmail. | |com, riggs@FreeBSD.org --- Comment #2 from John Hein --- This patch was added: % cat /usr/ports/multimedia//gstreamer1-plugins/files/patch-gst-libs_gst_allocato= rs_meson.build --- gst-libs/gst/allocators/meson.build.orig 2022-09-06 20:56:00 UTC +++ gst-libs/gst/allocators/meson.build @@ -1,3 +1,4 @@ +if get_option('allocators').enabled() gst_allocators_headers =3D files([ 'allocators.h', 'allocators-prelude.h', @@ -58,3 +59,4 @@ allocators_dep =3D declare_dependency(link_with: gstallo sources : allocators_gen_sources) meson.override_dependency('gstreamer-allocators-1.0', allocators_dep) +endif So, unless 'allocators' is explicitly enabled, allocators_dep is not define= d.=20=20 It's not clear from the commit or review why that is there (committer, maintainter CC'd for comment). But if you remove that patch, gstreamer1-plugins-gl gets past 'configure' w= hen libdrm is installed. Because the intent of the patch is not documented, I don't know what to test for breakage if the patch is removed. It may be something that fails to bu= ild, or it could cause some run-time problem, or maybe the patch should just not= be there at all and everything works fine without it. An answer from the patch author would be helpful here. By the way, the reason this only shows up when libdrm is installed is from = this meson.build snippet in work/gst-plugins-base-1.20.3/gts-libs/gl/meson.build: if egl_dep.found() and cc.has_header('libdrm/drm_fourcc.h') optional_deps +=3D allocators_dep endif --=20 You are receiving this mail because: You are the assignee for the bug.=