From owner-freebsd-ports@FreeBSD.ORG Sun Jun 24 18:25:06 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C94D6106567A for ; Sun, 24 Jun 2012 18:25:06 +0000 (UTC) (envelope-from jhellenthal@dataix.net) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7A0D08FC20 for ; Sun, 24 Jun 2012 18:25:06 +0000 (UTC) Received: by obbun3 with SMTP id un3so6699688obb.13 for ; Sun, 24 Jun 2012 11:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dataix.net; s=rsa; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to; bh=rzy6aQUwgwSQkT1zMd2cBaBQNjNPaGzKDkB+OHzXa0A=; b=G3XJMOD827XP3Wu8fUl7LiC+4mWrUoxWryzD1KRWxHVJEAz+kAZd272dW1q3G1cOB7 Cz0WAc4OI5hqmeYMaZsPhdwHAm4GScYJ025g271gpDGmoaXKryDlriRVA3eRt+R1QDsq zmfR5KaeoOS3BYDHXjoX1gA1ujTP/cLijLeR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:x-gm-message-state; bh=rzy6aQUwgwSQkT1zMd2cBaBQNjNPaGzKDkB+OHzXa0A=; b=Qktevws2VwM8j32mdOx8lsUWMMAH7iwjdlPz3I6n1UfF8nAmTYij3lHy04UMTPAnH7 uTwXS1Szx2eoD9hwFD5LcSmajTRL/j4BwcfQTR4h+OJaltLsf9LHCy8YEjqtLRz7V0C5 AAYLo/4kbh5fqs80+qBUensuwo7Sv7vA5i0+BrWijfVi1mN7LPw99/oDSnv+DDn9N8Kt Dk7DYV0S7WAFGaJFHgSIQ4ItmYiXAD5053yXlZC7V19KCcPg2RP8YSyIBST14ZHqVKiU VqwNNaPayAiltDeXBV6HE+Me9qrgu/hvYgQ9VWCdbBT0ds5MQERfX5WQamyux8+vWrK7 i2bQ== Received: by 10.50.169.33 with SMTP id ab1mr6303031igc.73.1340562305862; Sun, 24 Jun 2012 11:25:05 -0700 (PDT) Received: from DataIX.net (75-128-120-86.dhcp.aldl.mi.charter.com. [75.128.120.86]) by mx.google.com with ESMTPS id ch5sm4637013igb.0.2012.06.24.11.25.03 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Jun 2012 11:25:05 -0700 (PDT) Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.5/8.14.5) with ESMTP id q5OIOqKS005021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 24 Jun 2012 14:24:53 -0400 (EDT) (envelope-from jhellenthal@DataIX.net) Received: (from jh@localhost) by DataIX.net (8.14.5/8.14.5/Submit) id q5OIOqsu005020; Sun, 24 Jun 2012 14:24:52 -0400 (EDT) (envelope-from jhellenthal@DataIX.net) Date: Sun, 24 Jun 2012 14:24:52 -0400 From: "J. Hellenthal" To: Robert Simmons Message-ID: <20120624182452.GB4715@DataIX.net> References: <20120624171753.GA15646@DataIX.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Gm-Message-State: ALoCoQkRg25obazQlRyeJc+bw2Vz2GH2PWFNY8/7k+DSUnbuwB+5RdRxEZtjey5vNr/AGsBDShVI Cc: ports@freebsd.org Subject: Re: security/openssh-portable line # 82 of rc.d/openssh generates DSA not ECDSA X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2012 18:25:07 -0000 On Sun, Jun 24, 2012 at 01:46:20PM -0400, Robert Simmons wrote: > On Sun, Jun 24, 2012 at 1:17 PM, J. Hellenthal wrote: > > > > As stated in the subject > > > > if [ -f /usr/local/etc/ssh/ssh_host_ecdsa_key ]; then > >        echo "You already have a Elliptic Curve DSA host key" \ > >                "in /usr/local/etc/ssh/ssh_host_ecdsa_key" > >        echo "Skipping protocol version 2 Elliptic Curve DSA Key Generation" > > else > >        /usr/local/bin/ssh-keygen -t dsa \ > >                -f /usr/local/etc/ssh/ssh_host_ecdsa_key -N '' > > fi > > > > > > Specifically "/usr/local/bin/ssh-keygen -t dsa" needs to be changed to > > "-t ecdsa" to be correct. Otherwise we are just reimplementing a DSA key > > in a different file. > > Good eye. I'm in the process of updating that port to 6.0p1. There > are quite a lot of local patches that are part of the port. At the > moment I'm muddling through what they do and whether they can be > removed or not. I didn't even notice this problem. > > I've attached a pair of patches that correct this problem. Open a PR > about this, and you can attach these patches to it. I'm not the > maintainer nor do I have commit privileges, but if you open a PR, I'm > sure someone will make the change. Should have also said the changes were already committed. > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" -- - (2^(N-1))