From nobody Wed Dec 3 05:26:33 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dLmNC6XnLz6Hf4L for ; Wed, 03 Dec 2025 05:26:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dLmNC0Hv8z3DFM for ; Wed, 03 Dec 2025 05:26:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=vKQLgz8w; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::62d) smtp.mailfrom=wlosh@bsdimp.com Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-29853ec5b8cso76898125ad.3 for ; Tue, 02 Dec 2025 21:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1764739604; x=1765344404; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SGQybfttdsvorhLlm05XwE76pvK5uQZ4bK6zt2r2zm8=; b=vKQLgz8wczWvcNvKLHWBPRrhmMMJIqxu/YXfSNV2YUMmnyB7cwSc9xj3XkI/c5aWse jel+wfosTdkHt+CTLrsmDEiKKmxx9aVGpK/BRV0/sWHk0nQ3ccdm5bbxenaqkQkoYa3W slzJLdZ4B3EqCPIqdx9AuXmlOZMlPEEhPPvkLCMefW0O32RrBB04s8LydSXrfSlBcdVi BrUuxbIZSscAqmKwf8SzppXKb0NfJb5Mw22wJSuAi8/aZk3SF9BuxCy6R9w29mB7faAg QDUR3srn1KfS9CE1MvETpkvzdgoGcA5UmcbK2DK/WruJxIw0hGLqYge/olGq1lTbz+Fy jM+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764739604; x=1765344404; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SGQybfttdsvorhLlm05XwE76pvK5uQZ4bK6zt2r2zm8=; b=p41W/kcOVTz07Th46MLWawv4oDtHQQeemSOaY/9YHk4lbQ2JZ9jWUi6bvFjYGfgut5 1v2yoNAO1k/4zObxsiApVE29b/JEt+O5aDmUA9LWjyWrITnWTIDqLuiVwKEM52KfXFya EJjqQgHojppH6Hjec1pRvGtnFeySn2F5qx9ggBB16HpBajNY6DAIP/AJBVPJg6kZNH7k WHMHHpVcZA+XFAewrbr4Zk/oWvd5bH2JYNjQIuMT0jGSrONVkMGnFFUDjewwfqKBk++v nODfQ1jSgRdYw1qwT57YaPZnoRygAlzGFj6GMvrGjy090UuQ19zoSkhVCDzU9blYK0Qm DPZA== X-Forwarded-Encrypted: i=1; AJvYcCXQxNAewWyOIWc3Ri+RbQ8WrpkrW+hthJg9yR+z+AvjTWKxEGf3W4kuaibLqm8Q3qFTOPzHkDUjrbGuY7RPN26qy0+MuQ==@freebsd.org X-Gm-Message-State: AOJu0YzdlEHLsIdUmwc8upMsn4oN0UKpGsBZgwy+MARHJDyOq2NMXTrm 9GavuWwkepvIE/zarEYs9KxRZLTXtaCi5sxIjebme/a1CdH4+apuc02d13Zn+oBsZSNHXIx5LSW 5Zgqg8SRBOguUurpS1W47+57PW8Qb0F+caKGWZwFWzw== X-Gm-Gg: ASbGncsgUk1mGyqmhknc0NGITOLLI20upuxtym78Wd/qfY9BpVQhB9InQipkUfgK4/D S6wK0/rkLt5Z0DLmsnFazY3yiwt0pZO4oJG+4Hcj/kXlKHBMd2D7FoS6GMm7u7zFDvQmrIAg3dm SsgUVslId3YId/6L+xk+7zwchSbqr1v5TtvpsNRzCfwPpacESGL9GXEkyBXZW4BYKVoDLyDplR5 j1pCj3YSfgWND8CqGlte6prb4NUw48vLthHXwEkxTLAc+wx/ID7RWk41NyEQJHqTM2GK+W4hXDf +1GEmg== X-Google-Smtp-Source: AGHT+IGcSXhSgJF2I3MFFri6R7N5MSbh/XYj/PiHIxAfNDEV6erbIl8+tKXWI5nIS+h8i7q0ir1VZQ2T34uRXieeoQM= X-Received: by 2002:a17:902:e94e:b0:297:f8d9:aae7 with SMTP id d9443c01a7336-29d683add85mr12986925ad.46.1764739604384; Tue, 02 Dec 2025 21:26:44 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <692a8ea7.feb1.63d10382@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 2 Dec 2025 22:26:33 -0700 X-Gm-Features: AWmQ_bnXC4KBKqg_64Yynj09uRHbyCOMinVOJSbAjjpVnxQ8THb6-0qJicixXSk Message-ID: Subject: Re: git: f42421307b11 - main - sys: remove armv6/6.1 support from debug monitor To: John Baldwin Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Minsoo Choo Content-Type: multipart/alternative; boundary="0000000000003d9f6a06450575a8" X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::62d:from]; DMARC_NA(0.00)[bsdimp.com]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; R_SPF_NA(0.00)[no SPF record]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4dLmNC0Hv8z3DFM --0000000000003d9f6a06450575a8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 1, 2025 at 8:18=E2=80=AFAM John Baldwin wrote= : > On 11/29/25 01:11, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Df42421307b115345ea1a6c8fdf61fbb= 581e4400f > > > > commit f42421307b115345ea1a6c8fdf61fbb581e4400f > > Author: Minsoo Choo > > AuthorDate: 2025-11-29 00:34:40 +0000 > > Commit: Warner Losh > > CommitDate: 2025-11-29 04:56:36 +0000 > > > > sys: remove armv6/6.1 support from debug monitor > > > > Signed-off-by: Minsoo Choo > > Reviewed by: imp > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1903 > > --- > > sys/arm/arm/debug_monitor.c | 30 ------------------------------ > > 1 file changed, 30 deletions(-) > > > > diff --git a/sys/arm/arm/debug_monitor.c b/sys/arm/arm/debug_monitor.c > > index 7944becbae4d..4d61896a2142 100644 > > --- a/sys/arm/arm/debug_monitor.c > > +++ b/sys/arm/arm/debug_monitor.c > > @@ -83,8 +83,6 @@ static uint32_t dbg_breakpoint_num; > > #define ID_DFR0_CP_DEBUG_M_SHIFT 0 > > #define ID_DFR0_CP_DEBUG_M_MASK (0xF << > ID_DFR0_CP_DEBUG_M_SHIFT) > > #define ID_DFR0_CP_DEBUG_M_NS (0x0) /* Not supported */ > > -#define ID_DFR0_CP_DEBUG_M_V6 (0x2) /* v6 Debug arch. > CP14 access */ > > -#define ID_DFR0_CP_DEBUG_M_V6_1 (0x3) /* v6.1 Debug arch. > CP14 access */ > > #define ID_DFR0_CP_DEBUG_M_V7 (0x4) /* v7 Debug arch. > CP14 access */ > > #define ID_DFR0_CP_DEBUG_M_V7_1 (0x5) /* v7.1 Debug arch. > CP14 access */ > > Humm, I would have probably left these as the register is still valid and > I find it > useful to describe the full range of values for registers that we define > constants for. > The rest of the removal certainly makes sense. > Sure. > > > > @@ -594,10 +592,6 @@ dbg_enable_monitor(void) > > dbg_dscr =3D cp14_dbgdscrint_get(); > > > > switch (dbg_model) { > > - case ID_DFR0_CP_DEBUG_M_V6: > > - case ID_DFR0_CP_DEBUG_M_V6_1: /* fall through */ > > - cp14_dbgdscr_v6_set(dbg_dscr | DBGSCR_MDBG_EN); > > - break; > > Should this function also be removed? Looks to be defined here in > sys/arm/include/cpu.h: > > _WF1(cp14_dbgdscr_v6_set, CP14_DBGDSCRext_V6(%0)) > OK. I'll do these tweaks.. Warner --0000000000003d9f6a06450575a8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Dec 1, = 2025 at 8:18=E2=80=AFAM John Baldwin <jhb@freebsd.org> wrote:
On 11/29/25 01:11, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Df42421307b115345ea1a6c8fdf61fbb581e4400f<= /a>
>
> commit f42421307b115345ea1a6c8fdf61fbb581e4400f
> Author:=C2=A0 =C2=A0 =C2=A0Minsoo Choo <minsoochoo0122@proton.me>
> AuthorDate: 2025-11-29 00:34:40 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2025-11-29 04:56:36 +0000
>
>=C2=A0 =C2=A0 =C2=A0 sys: remove armv6/6.1 support from debug monitor >=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>=
>=C2=A0 =C2=A0 =C2=A0 Reviewed by: imp
>=C2=A0 =C2=A0 =C2=A0 Pull Request: https://githu= b.com/freebsd/freebsd-src/pull/1903
> ---
>=C2=A0 =C2=A0sys/arm/arm/debug_monitor.c | 30 -------------------------= -----
>=C2=A0 =C2=A01 file changed, 30 deletions(-)
>
> diff --git a/sys/arm/arm/debug_monitor.c b/sys/arm/arm/debug_monitor.c=
> index 7944becbae4d..4d61896a2142 100644
> --- a/sys/arm/arm/debug_monitor.c
> +++ b/sys/arm/arm/debug_monitor.c
> @@ -83,8 +83,6 @@ static uint32_t dbg_breakpoint_num;
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0ID_DFR0_CP_DEBUG_M_SHIFT=C2=A0 = =C2=A0 =C2=A0 =C2=A0 0
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0ID_DFR0_CP_DEBUG_M_MASK=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(0xF << ID_DFR0_CP_DEBUG_M_SHIFT)
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0ID_DFR0_CP_DEBUG_M_NS=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(0x0) /* Not supported */
> -#define=C2=A0 =C2=A0 =C2=A0 ID_DFR0_CP_DEBUG_M_V6=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0(0x2) /* v6 Debug arch. CP14 access */
> -#define=C2=A0 =C2=A0 =C2=A0 ID_DFR0_CP_DEBUG_M_V6_1=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(0x3) /* v6.1 Debug arch. CP14 access */
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0ID_DFR0_CP_DEBUG_M_V7=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(0x4) /* v7 Debug arch. CP14 access */
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0ID_DFR0_CP_DEBUG_M_V7_1=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(0x5) /* v7.1 Debug arch. CP14 access */

Humm, I would have probably left these as the register is still valid and I= find it
useful to describe the full range of values for registers that we define co= nstants for.
The rest of the removal certainly makes sense.

Sure.
=C2=A0
>=C2=A0 =C2=A0
> @@ -594,10 +592,6 @@ dbg_enable_monitor(void)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0dbg_dscr =3D cp14_dbgdscrint_get();
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0switch (dbg_model) {
> -=C2=A0 =C2=A0 =C2=A0case ID_DFR0_CP_DEBUG_M_V6:
> -=C2=A0 =C2=A0 =C2=A0case ID_DFR0_CP_DEBUG_M_V6_1: /* fall through */<= br> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cp14_dbgdscr_v6_set(d= bg_dscr | DBGSCR_MDBG_EN);
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;

Should this function also be removed?=C2=A0 Looks to be defined here in sys= /arm/include/cpu.h:

_WF1(cp14_dbgdscr_v6_set, CP14_DBGDSCRext_V6(%0))

=
OK. I'll do these tweaks..

Warner
=C2=A0
--0000000000003d9f6a06450575a8--