From owner-dev-commits-ports-main@freebsd.org Mon Jul 5 07:08:20 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 25C7B655681; Mon, 5 Jul 2021 07:08:20 +0000 (UTC) (envelope-from lbartoletti@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GJGxJ0bGSz4S5r; Mon, 5 Jul 2021 07:08:20 +0000 (UTC) (envelope-from lbartoletti@FreeBSD.org) Received: from iMac-de-Loic.local (unknown [IPv6:2a01:e34:ef45:d440:6d65:71cb:f09b:c54f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: lbartoletti) by smtp.freebsd.org (Postfix) with ESMTPSA id 6C18B28BB5; Mon, 5 Jul 2021 07:08:19 +0000 (UTC) (envelope-from lbartoletti@FreeBSD.org) Subject: Re: git: be86c4fe23e0 - main - misc/qtchooser: remove To: Christoph Moench-Tegeder Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202107041732.164HW8HQ076467@gitrepo.freebsd.org> From: =?UTF-8?Q?Lo=c3=afc_Bartoletti?= Message-ID: <2569fab0-d643-e22a-0d3a-2e4df497c75f@FreeBSD.org> Date: Mon, 5 Jul 2021 09:08:15 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 07:08:20 -0000 Hello, Le 04/07/2021 à 23:28, Christoph Moench-Tegeder a écrit : > ## Loïc Bartoletti (lbartoletti@FreeBSD.org): > This: > >> misc/qtchooser: remove > Does more than it says on the label: Indeed, removing a tool like this one cannot be done without patching (many) other ports. > >> --- a/cad/freecad/Makefile >> +++ b/cad/freecad/Makefile >> -USES= dos2unix compiler:c++11-lib cmake gl eigen:3 fortran jpeg \ >> +USES= dos2unix compiler:c++17-lang cmake gl eigen:3 fortran jpeg \ >> + -DBUILD_ENABLE_CXX_STD=C++17 Sorry, this line is not needed to build cad/freecad without qtchooser. I added it during my tests, because I saw that it was necessary to reduce some warnings, but it's not useful for this change. > I'd appricate knowing why these additional changes happen - it reduces > annoyances on my side when these changes interfere with other patches > I've lined up (yeah, I should just commit faster, but sometimes live > happens). We have communicated in the past, publicly or directly with those affected, like you, for this kind of improvement. Although this initiative has been public for several months, it may not have been visible. I will ensure better communication for the next times. Regards, Loïc > > Regards, > Christoph >