From owner-freebsd-hackers Wed Aug 18 10:27:25 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 58B2B14C80; Wed, 18 Aug 1999 10:27:20 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id TAA01171; Wed, 18 Aug 1999 19:24:04 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Terry Lambert Cc: michaelh@cet.co.jp (Michael Hancock), wrstuden@nas.nasa.gov, Matthew.Alton@anheuser-busch.com, Hackers@FreeBSD.ORG, fs@FreeBSD.ORG Subject: Re: BSD XFS Port & BSD VFS Rewrite In-reply-to: Your message of "Wed, 18 Aug 1999 17:16:46 -0000." <199908181716.KAA12220@usr02.primenet.com> Date: Wed, 18 Aug 1999 19:24:04 +0200 Message-ID: <1169.934997044@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <199908181716.KAA12220@usr02.primenet.com>, Terry Lambert writes: >> > > I'm not familiar with the VFS_default stuff. All the vop_default_desc >> > > routines in NetBSD point to error routines. >> > >> > In FreeBSD, they now point to default routines that are *not* error >> > routines. This is the problem. I admit the change was very well >> > intentioned, since it made the code a hell of a lot more readable, >> > but choosing between readable and additional function, I take function >> > over form (I think the way I would have "fixed" the readability is by >> > making the operations that result in the descriptor set for a mounted >> > FS instance be both discrete, and named for their specific function). >> >> As I recall most of FBSD's default routines are also error routines, if >> the exceptions were a problem it would would be trivial to fix. > >You would have to de-collapse several VOP lists that have been >pre-collapsed. You are talking gibberish here. Please show code where this is a problem. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message