From owner-cvs-src@FreeBSD.ORG Wed Nov 9 15:43:43 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ED2016A4E8; Wed, 9 Nov 2005 15:43:43 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail5.speedfactory.net [66.23.216.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF2E443D48; Wed, 9 Nov 2005 15:43:42 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 1647457 for multiple; Wed, 09 Nov 2005 10:45:27 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jA9FhHqa035637; Wed, 9 Nov 2005 10:43:18 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Wed, 9 Nov 2005 10:01:42 -0500 User-Agent: KMail/1.8.2 References: <200511090732.jA97W2ir099375@repoman.freebsd.org> <20051109204951.K68350@delplex.bde.org> <4371FFF1.7020902@samsco.org> In-Reply-To: <4371FFF1.7020902@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200511091001.45475.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Warner Losh , cvs-all@freebsd.org, Bruce Evans Subject: Re: cvs commit: src/sys/kern subr_power.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2005 15:43:43 -0000 On Wednesday 09 November 2005 08:56 am, Scott Long wrote: > Bruce Evans wrote: > > On Wed, 9 Nov 2005, Warner Losh wrote: > >> Modified files: > >> sys/kern subr_power.c > >> Log: > >> Kick off the suspend sequence from the keyboard in a SWI rather than > >> in the hardware interrupt context (even if it is likely just an > >> ithread). We don't document that suspend/resume routines are run from > >> such a context and some of the things that happen in those routines > >> aren't interrupt safe. Since there's no real need to run from that > >> context, this restores assumptions that suspend routines have made. > >> > >> This fixes Thierry Herbelot's 'Trying to sleep while sleeping is > >> prohibited' problem. > > > > Er, SWIs are interrupts too. Trying to sleep in a SWI handler should > > cause the same message. This commit uses the general taskqueue SWI > > handler. taskqueue(9) implicitly says that only the taskqueue thread > > handler can sleep (it gives malloc(M_WAITOK) as an example of something > > that can only be done in thread context). > > > > Bruce > > You're right, but sleeping in SWI's has never been enforced. CAM relies > on it, for better or worse, and until that's fixed it's pointless to > start enforcing it. Well, I don't think we should knowingly go around adding more instances of it. :) In this case it is really easy to just use taskqueue_thread rather than taskqueue_swi. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org