From owner-cvs-all Mon Jun 24 8:23:21 2002 Delivered-To: cvs-all@freebsd.org Received: from corbulon.video-collage.com (corbulon.video-collage.com [64.35.99.179]) by hub.freebsd.org (Postfix) with ESMTP id 4B42637B405; Mon, 24 Jun 2002 08:23:15 -0700 (PDT) Received: from misha (250-217.customer.cloud9.net [168.100.250.217]) by corbulon.video-collage.com (8.12.2/8.12.2) with ESMTP id g5OFNCQC081429 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=FAIL); Mon, 24 Jun 2002 11:23:13 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) X-Authentication-Warning: corbulon.video-collage.com: Host 250-217.customer.cloud9.net [168.100.250.217] claimed to be misha Content-Type: text/plain; charset="koi8-u" From: Mikhail Teterin Organization: Virtual Estates, Inc. To: Poul-Henning Kamp , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libmd md5c.c Date: Mon, 24 Jun 2002 11:23:00 -0400 X-Mailer: KMail [version 1.4] References: <200206221254.g5MCsBt36492@freefall.freebsd.org> In-Reply-To: <200206221254.g5MCsBt36492@freefall.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <200206241123.00587.mi+mx@aldan.algebra.com> X-Scanned-By: MIMEDefang 2.15 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Saturday 22 June 2002 08:54 am, Poul-Henning Kamp wrote: = phk 2002/06/22 05:54:11 PDT = = Modified files: = lib/libmd md5c.c = Log: = Improve the handling of Encode and Decode operations in MD5. = = Use memcpy for all little-endian architectures, sys/kern/md5c.c = indicates this should be safe for all currently supported LE archs. = = Change the Encode and Decode functions for other archs to use = le32toh() and htole32() functions instead of explicit byte = shuffling. = = On sparc64 this gives md5(1) about 8% speed increase. Great, but what about the rest of the mdXc.c? At least, md4c has a very similar Encode(). Also, how about adding an attempt to use mmap to the MDXFileChunk(3) -- while you are there :-) ? Getting rid of the buffer and calling MDXUpdate just once should be quite helpful too... Yours, -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message