From owner-freebsd-bugs@FreeBSD.ORG Wed Apr 13 22:10:15 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20D1116A4CE for ; Wed, 13 Apr 2005 22:10:15 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC80043D4C for ; Wed, 13 Apr 2005 22:10:14 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3DMAEqE022086 for ; Wed, 13 Apr 2005 22:10:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3DMAE2k022085; Wed, 13 Apr 2005 22:10:14 GMT (envelope-from gnats) Resent-Date: Wed, 13 Apr 2005 22:10:14 GMT Resent-Message-Id: <200504132210.j3DMAE2k022085@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Wojciech A. Koszek" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 097F616A4CE for ; Wed, 13 Apr 2005 22:03:50 +0000 (GMT) Received: from freebsd.czest.pl (silver.iplus.pl [80.48.250.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9CB9243D39 for ; Wed, 13 Apr 2005 22:03:48 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4]) by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id j3DMCUKf043433 for ; Wed, 13 Apr 2005 22:12:30 GMT (envelope-from dunstan@freebsd.czest.pl) Received: (from dunstan@localhost) by freebsd.czest.pl (8.12.10/8.12.9/Submit) id j3DMCTRM043432; Wed, 13 Apr 2005 22:12:29 GMT (envelope-from dunstan) Message-Id: <200504132212.j3DMCTRM043432@freebsd.czest.pl> Date: Wed, 13 Apr 2005 22:12:29 GMT From: "Wojciech A. Koszek" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/79884: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Wojciech A. Koszek" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2005 22:10:15 -0000 >Number: 79884 >Category: kern >Synopsis: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 13 22:10:14 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Wojciech A. Koszek >Release: FreeBSD 5.4-STABLE i386 >Organization: >Environment: System: FreeBSD dunstan.freebsd.czest.pl 5.4-STABLE FreeBSD 5.4-STABLE #7: Tue Apr 12 00:11:29 CEST 2005 dunstan@dunstan.freebsd.czest.pl:/usr/obj/usr/src/sys/HOME8 i386 >Description: NG_FWD_ITEM_HOOK prepends to "error" appropriate value if needed. Currently, "error" is not used after NG_FWD_ITEM_HOOK. ng_echo(4) should make use of it. >How-To-Repeat: cvs -d anoncvs@anoncvs.fr.freebsd.org:/home/ncvs co -p src/sys/netgraph/ng_echo.c | cat -n | grep 106 >Fix: Patch [diff.0.ng_echo.c] corrects this mistake. --- diff.0.ng_echo.c begins here --- Index: src/sys/netgraph/ng_echo.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_echo.c,v retrieving revision 1.12 diff -r1.12 ng_echo.c 106c106 < return (0); --- > return (error); --- diff.0.ng_echo.c ends here --- >Release-Note: >Audit-Trail: >Unformatted: