Date: Sat, 21 Feb 2009 21:02:53 +0000 (UTC) From: Alan Cox <alc@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r188901 - user/alc/pagelock/sys/vm Message-ID: <200902212102.n1LL2rk3075321@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: alc Date: Sat Feb 21 21:02:53 2009 New Revision: 188901 URL: http://svn.freebsd.org/changeset/base/188901 Log: Eliminate page queues locking from vm_object_page_clean(). Modified: user/alc/pagelock/sys/vm/vm_object.c Modified: user/alc/pagelock/sys/vm/vm_object.c ============================================================================== --- user/alc/pagelock/sys/vm/vm_object.c Sat Feb 21 20:57:25 2009 (r188900) +++ user/alc/pagelock/sys/vm/vm_object.c Sat Feb 21 21:02:53 2009 (r188901) @@ -740,7 +740,6 @@ vm_object_page_clean(vm_object_t object, tend = end; } - vm_page_lock_queues(); /* * If the caller is smart and only msync()s a range he knows is * dirty, we may be able to avoid an object scan. This results in @@ -802,7 +801,6 @@ vm_object_page_clean(vm_object_t object, * return immediately. */ if (tscan >= tend && (tstart || tend < object->size)) { - vm_page_unlock_queues(); vm_object_clear_flag(object, OBJ_CLEANING); return; } @@ -889,7 +887,6 @@ again: goto again; } } - vm_page_unlock_queues(); #if 0 VOP_FSYNC(vp, (pagerflags & VM_PAGER_PUT_SYNC)?MNT_WAIT:0, curproc); #endif @@ -911,10 +908,8 @@ vm_object_page_collect_flush(vm_object_t vm_page_t mab[vm_pageout_page_count]; vm_page_t ma[vm_pageout_page_count]; - mtx_assert(&vm_page_queue_mtx, MA_OWNED); pi = p->pindex; while (vm_page_sleep_if_busy(p, TRUE, "vpcwai")) { - vm_page_lock_queues(); if (object->generation != curgeneration) { return(0); } @@ -980,7 +975,9 @@ vm_object_page_collect_flush(vm_object_t } runlen = maxb + maxf + 1; + vm_page_lock_queues(); vm_pageout_flush(ma, runlen, pagerflags); + vm_page_unlock_queues(); for (i = 0; i < runlen; i++) { if (ma[i]->valid & ma[i]->dirty) { pmap_remove_write(ma[i]);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902212102.n1LL2rk3075321>