From owner-freebsd-ports@FreeBSD.ORG Tue Feb 8 19:45:42 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A597916A4CE for ; Tue, 8 Feb 2005 19:45:42 +0000 (GMT) Received: from gate.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0103543D3F for ; Tue, 8 Feb 2005 19:45:42 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by gate.xbsd.org (Postfix) with ESMTP id 03EDC119ED; Tue, 8 Feb 2005 20:48:32 +0100 (CET) Received: from gate.xbsd.org ([127.0.0.1]) by localhost (gate.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 77961-03; Tue, 8 Feb 2005 20:48:27 +0100 (CET) Received: from [192.168.42.3] (innercity.xbsd.org [192.168.42.3]) by gate.xbsd.org (Postfix) with ESMTP id 25212119D2; Tue, 8 Feb 2005 20:48:27 +0100 (CET) Message-ID: <420916D8.90606@xbsd.org> Date: Tue, 08 Feb 2005 20:45:28 +0100 From: Florent Thoumie User-Agent: Mozilla Thunderbird 1.0 (X11/20050107) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Yar Tikhiy References: <42075175.20603@ntmk.ru> <20050207125420.GA85693@heechee.tobez.org> <20050207154456.GB65425@comp.chem.msu.su> <420794CC.1070604@xbsd.org> <20050208193307.GB43153@comp.chem.msu.su> In-Reply-To: <20050208193307.GB43153@comp.chem.msu.su> X-Enigmail-Version: 0.89.6.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC28EBE592E23E3AC106DF12D" X-Virus-Scanned: amavisd-new at xbsd.org cc: Boris Kovalenko cc: freebsd-ports@freebsd.org Subject: Re: We need new feature for pkg_create? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2005 19:45:42 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC28EBE592E23E3AC106DF12D Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Yar Tikhiy wrote: > On Mon, Feb 07, 2005 at 05:18:20PM +0100, Florent Thoumie wrote: > >>>IMHO, what we need is a way to restore the initial prefix setting >>>in a packing list. The idea of @pushwd and @popwd looks really >>>neat to me. With those commands available, it would be possible >>>to append lines using %D or just assuming the current prefix is the >>>right one to the final packing list from bsd.port.mk without breaking >>>"pkg_add -p /foo". >>> >>>BTW, here's an example that the problem is rather general. Currently >>>using @cwd in port's pkg-plist and PORTDOCS in its Makefile results >>>precisely in broken "pkg_add -p /foo" because the build-time prefix >>>gets hardcoded in the packing list. >> >> I don't like the idea of a "working directory" stack because at >> most, you'll push one time (or your port is behaving weirdly). > > > This makes sense to me. I updated the patch this afternoon, this worked for me but everyone should be aware that even with this patch, pkg_add -p will still not work for a lot of ports since the original prefix is often hardcoded during port compilation. >> FWIW, I just sent a PR with a patch to address this issue [1]. >> Feel free to add comments in the audit trail. >> >> [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=77212 > > > /usr/src/MAINTAINERS lists eik@freebsd.org as the maintainer of > src/usr.sbin/pkg_install. IMHO it should be reasonable to draw > his attention to your PR. According to krion, pkg_install is portmgr territory. I have cc'ed eik in my last reply though. -- Florent Thoumie flz@xbsd.org --------------enigC28EBE592E23E3AC106DF12D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCCRbdMxEkbVFH3PQRAuXeAJ4o0RXq+fxKX1YldxKR5ti5J/EKIgCffOJx 5W/B+GP3jR3Q+Ky0QLLvv2E= =5aNi -----END PGP SIGNATURE----- --------------enigC28EBE592E23E3AC106DF12D--