From owner-svn-src-all@FreeBSD.ORG Tue Aug 10 07:42:15 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 497F61065672; Tue, 10 Aug 2010 07:42:15 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from fep14.mx.upcmail.net (fep14.mx.upcmail.net [62.179.121.34]) by mx1.freebsd.org (Postfix) with ESMTP id 3D8CD8FC15; Tue, 10 Aug 2010 07:42:13 +0000 (UTC) Received: from edge04.upcmail.net ([192.168.13.239]) by viefep14-int.chello.at (InterMail vM.8.01.02.02 201-2260-120-106-20100312) with ESMTP id <20100810074212.UNOQ8381.viefep14-int.chello.at@edge04.upcmail.net>; Tue, 10 Aug 2010 09:42:12 +0200 Received: from mole.fafoe.narf.at ([213.47.85.26]) by edge04.upcmail.net with edge id sXiA1e05H0a5KZh04XiCfb; Tue, 10 Aug 2010 09:42:12 +0200 X-SourceIP: 213.47.85.26 Received: by mole.fafoe.narf.at (Postfix, from userid 1001) id C9BA26D438; Tue, 10 Aug 2010 09:42:10 +0200 (CEST) Date: Tue, 10 Aug 2010 09:42:10 +0200 From: Stefan Farfeleder To: "Jayachandran C." Message-ID: <20100810074210.GC1737@mole.fafoe.narf.at> References: <201008100515.o7A5FZZF017552@svn.freebsd.org> <20100810062829.GA1737@mole.fafoe.narf.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Cloudmark-Analysis: v=1.1 cv=M71sKKeyFebLYdq5hFNIGMR02ATQkL1qNhm49ttUYSY= c=1 sm=0 a=HLCT0tXVX6QA:10 a=kj9zAlcOel0A:10 a=0ygLJXLVLYis7nSBnPkA:9 a=d9FEsC_lMa7Qp0DW8373jy9HAs8A:4 a=CjuIK1q_8ugA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Neel Natu Subject: Re: svn commit: r211130 - head/libexec/rtld-elf/mips X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2010 07:42:15 -0000 On Tue, Aug 10, 2010 at 12:55:38PM +0530, Jayachandran C. wrote: > > I think there is a problem in sys/mips/include/_endian.h > -- > #define __bswap16(x) (__uint16_t)(__is_constant(x) ? \ > __bswap16_const((__uint16_t)x) : __bswap16_var((__uint16_t)x)) > #define __bswap32(x) (__uint32_t)(__is_constant(x) ? \ > __bswap32_const((__uint32_t)x) : __bswap32_var((__uint32_t)x)) > #define __bswap64(x) (__uint64_t)(__is_constant(x) ? \ > __bswap64_const((__uint64_t)x) : __bswap64_var((__uint64_t)x)) > -- > > I'm not sure why the cast is needed, but we should have a braces > around x, unless I'm completely mistaken. I agree. And around the entire expression too. Stefan