From owner-svn-src-all@freebsd.org  Tue Jun 30 03:19:43 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE061990829;
 Tue, 30 Jun 2015 03:19:43 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "vps1.elischer.org",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 942AD2CFA;
 Tue, 30 Jun 2015 03:19:43 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from Julian-MBP3.local
 (ppp121-45-252-104.lns20.per4.internode.on.net [121.45.252.104])
 (authenticated bits=0)
 by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t5U3JZFn092080
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Mon, 29 Jun 2015 20:19:39 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Message-ID: <55920AC2.3060809@freebsd.org>
Date: Tue, 30 Jun 2015 11:19:30 +0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Ed Schouten <ed@nuxi.nl>, Konstantin Belousov <kib@freebsd.org>
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r284887 - in head/sys: kern sys ufs/ffs
References: <201506270944.t5R9iEjO053344@svn.freebsd.org>
 <CABh_MKk-48D4FP-BgNLxvVuw4=3_YKnTX-5kSdL7LSAjCVCNOg@mail.gmail.com>
In-Reply-To: <CABh_MKk-48D4FP-BgNLxvVuw4=3_YKnTX-5kSdL7LSAjCVCNOg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jun 2015 03:19:43 -0000

On 6/29/15 8:19 PM, Ed Schouten wrote:
> Hi Kostik,
>
> 2015-06-27 11:44 GMT+02:00 Konstantin Belousov <kib@freebsd.org>:
>> @@ -2056,6 +2072,8 @@ ffs_bufwrite(struct buf *bp)
>>                  if (bp->b_vflags & BV_BKGRDINPROG)
>>                          panic("bufwrite: still writing");
>>          }
>> +       if ((bp->b_vflags & BV_BKGRDERR) != 0)
>> +               bp->b_vflags &= ~BV_BKGRDERR;
>>          BO_UNLOCK(bp->b_bufobj);
>>
>>          /*
> This if-statement could be removed, right? The bit could just be
> cleared unconditionally.
true but it replaces a read and write with just a read in the case of 
no change.
> Best regards,