From nobody Tue Jun 3 21:25:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bBkKP3BD0z5yB8M; Tue, 03 Jun 2025 21:26:01 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bBkKP2Pdrz3JJb; Tue, 03 Jun 2025 21:26:01 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748985961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9GXiGwfLOsafNriCy4cjRVqhqmXZLWTYX/kSYSKl30s=; b=Mdaz5kv9vqbgh9pnV8bTGHY+B3BpOqkrTJnWoeC3WrQWEeNFKyP0/uOhIuygS5JHSgMGYR zJRSMf4SvxUCCpYhkUyDV0GUJ6kVdOb/qL24nSgqoIJ7wuuzl353csC80TFuhrEeszIR28 MS4b4bYRFiJDODMlDLX2XQxe7QfiPKXp+PV3ZMTGKKDcCdvY5On5yFWUezInPqhTQ2LYx4 ol+/HxArAw8LHUcOk0zn37LjSo0F5vUlf6bTv+NRApctJVWYuxB89vJ3yEVt3EDpeBE6l7 NjJiy5fObsJ1exBC1LuGamLTkZRUoQTsujq7KU9+HKbKtzcfyDSGOBJZr+fSPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748985961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9GXiGwfLOsafNriCy4cjRVqhqmXZLWTYX/kSYSKl30s=; b=UstCeOpLItLv0OAKbZc0gUcbHbeGxCRl38peJDbTn5pfjb9FCAdy7+giThZWTQEAHmi/8h HtrI3Ukv74EyZD9i+aO9mluSgK8zckx5oLWvsAWfcVe8jOH4S/Y7VHm9/Ypx0ZZwsRtnUi 00v4GcTzqoQLd+Q8AeLASdxsXpWjkWB2YcAiVuouVGgwiQ11pxiMycBF5jRUh6dSECf7FT 35YWaULoMtTHN3PHizwcBOg65D12LJ8hAdyucLf8FK9WJLINp35WA1bzwFJfejjoDCiC6o /yXOziRw6kwfs1rYpInF85n79SJvMnRXCH/FTlIAs3q2EU5gNeEbpGLtsW0SRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748985961; a=rsa-sha256; cv=none; b=H6533gUTFQx+H4/3qRUWxSLOMw32T5azYVLWwYreWyBZBAoev171T1zmL+kunOEPtdIgEE NBZn5k0sdyvrovO27fNy+1CIFt4YpGLQq2E9nowuok1E1sLoV53IyLOk+p1nBX3jySYoI+ 2oZk1EetAH9e7dXvy7hafHH5lO0NYniZc3+Dj7u7pjdg2fEVUn7tkXcyfzYH1scv2sAvT7 ntpH+9XoPBhxJwra2YAID+syL6AdIWUX3zmVsxNGcs2PPXKJ3Clz02ZobceHxkmxpbhExw xfVIYqXbtypShLMU/BnxpXaWCowNRw8NCjeGD8/3BNdFRIHG/BhDwLi7MDQU5Q== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E5" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bBkKP0lqXz1BW3; Tue, 03 Jun 2025 21:26:01 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 27416A64805; Tue, 03 Jun 2025 21:25:58 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 0FBB32D029E0; Tue, 3 Jun 2025 21:25:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id oyCQojxXlTg6; Tue, 3 Jun 2025 21:25:58 +0000 (UTC) Received: from strong-rtwn0.sbone.de (strong-rtwn0.sbone.de [IPv6:fde9:577b:c1a9:4902:3e64:cfff:fe55:bc80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id E86492D029D8; Tue, 3 Jun 2025 21:25:57 +0000 (UTC) Date: Tue, 3 Jun 2025 21:25:56 +0000 (UTC) From: "Bjoern A. Zeeb" To: Konstantin Belousov cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9a139facd06e - main - pseudofs: enhance KASSERT with more information In-Reply-To: Message-ID: <9112s3o2-7n79-s55s-7p95-77no5q1pp6q0@serrofq.bet> References: <202506031125.553BPHor094136@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 3 Jun 2025, Konstantin Belousov wrote: > On Tue, Jun 03, 2025 at 11:25:17AM +0000, Bjoern A. Zeeb wrote: >> The branch main has been updated by bz: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=9a139facd06e4a1159a9c2cb992d04bcf1079e7e >> >> commit 9a139facd06e4a1159a9c2cb992d04bcf1079e7e >> Author: Bjoern A. Zeeb >> AuthorDate: 2025-06-03 11:20:56 +0000 >> Commit: Bjoern A. Zeeb >> CommitDate: 2025-06-03 11:25:00 +0000 >> >> pseudofs: enhance KASSERT with more information >> >> Add the name and type information to a KASSERT for 'homonymous siblings'. >> Without this (or a core file) we do not even know which entry to look >> for. This should make reporting and debugging a tad more simple. >> >> Prompted by: PR 287165 >> --- >> sys/fs/pseudofs/pseudofs.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/sys/fs/pseudofs/pseudofs.c b/sys/fs/pseudofs/pseudofs.c >> index eb4ca8a82456..d8dbf7117d13 100644 >> --- a/sys/fs/pseudofs/pseudofs.c >> +++ b/sys/fs/pseudofs/pseudofs.c >> @@ -124,7 +124,8 @@ pfs_add_node(struct pfs_node *parent, struct pfs_node *pn) >> ("%s(): nested process directories", __func__)); >> for (iter = parent->pn_nodes; iter != NULL; iter = iter->pn_next) { >> KASSERT(strcmp(pn->pn_name, iter->pn_name) != 0, >> - ("%s(): homonymous siblings", __func__)); >> + ("%s(): homonymous siblings: '%s' type %d", __func__, >> + pn->pn_name, pn->pn_type)); >> if (pn->pn_type == pfstype_procdir) >> KASSERT(iter->pn_type != pfstype_procdir, >> ("%s(): sibling process directories", __func__)); > > May be it is time to finally make this check a runtime one. > D50669 Can the callers deal with that? lindebugfs etc.? or will we just see different panics (less clear)? The problem that kargl is running into seems that drm-kmod/radeon is double-initialising and radeon has no cleanup routine hooked up most likely (or none which I could identify on quick look). No idea how this works on Linux but I know I had to fix wifi drivers as once I had two cards directories on FreeBSD were identical otherwise. /bz -- Bjoern A. Zeeb r15:7