From owner-freebsd-wireless@FreeBSD.ORG Tue Feb 14 18:43:34 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EFCD9106566C; Tue, 14 Feb 2012 18:43:34 +0000 (UTC) (envelope-from monthadar@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9B8948FC18; Tue, 14 Feb 2012 18:43:34 +0000 (UTC) Received: by yhfs35 with SMTP id s35so258189yhf.13 for ; Tue, 14 Feb 2012 10:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=eySPI+c3Uieyrw4njliKOZMgHpQ83z80sb+DnvTYnT0=; b=sN48aI6r1QNIuuibJWQmTEf6eg9rJMHw3KJGNMx9Af+zrfTenSY6QS/g+B9yV2UNXf unIpPhGjNBKh8dKJy0aYzVps+k+qPWMk6Fi4gUI+7UCyPpVWwbgKjQUhfTIbpeYXmjbl 6x3/GbhI67SMoVmnAhxcGBxFqaLsK1TJygfYs= MIME-Version: 1.0 Received: by 10.50.85.231 with SMTP id k7mr6278535igz.25.1329245013652; Tue, 14 Feb 2012 10:43:33 -0800 (PST) Received: by 10.50.213.74 with HTTP; Tue, 14 Feb 2012 10:43:33 -0800 (PST) In-Reply-To: References: Date: Tue, 14 Feb 2012 19:43:33 +0100 Message-ID: From: Monthadar Al Jaberi To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: Fragment number of first fragment != 0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2012 18:43:35 -0000 done; http://www.freebsd.org/cgi/query-pr.cgi?pr=165146 br On Tue, Feb 14, 2012 at 5:03 PM, Adrian Chadd wrote: > .. I think the answer is "yes". > > Please create a PR with what you've put in this email and a patch to fix it. > > I'll commit that fix today :0 > > > adrian > > On 14 February 2012 00:26, Adrian Chadd wrote: >> Lemme check into this a little more.. >> >> >> adrian >> >> On 14 February 2012 00:19, Monthadar Al Jaberi wrote: >>> Hi, >>> >>> I found that in FreeBSD current the first fragment will have a >>> fragment number = 1 in function ieee80211_fragment. >>> >>> But according to 802.11-2007, 9.4 Fragmentation page 279: >>> "...The fragments shall be sent in order of lowest fragment number to >>> highest fragment >>> number, where the fragment number value starts at zero, ..." >>> >>> This also holds on the 802.11-2011 draft 12: >>> "The fragment number is set to 0 in the first or only fragment of an >>> MSDU or MMPDU and is >>> incremented by one for each successive fragment of that MSDU or MMPDU." >>> >>> I checked Linux 3.3-rc3 code and there I see them having a check on rx side >>> if (frag == 0) { /* This is the first fragment of a new frame. */ >>> and on tx side they put: >>> fragnum = 0; >>> >>> On Madwifi 0.9.4 in function ieee80211_encap: >>> fragnum = 0; >>> >>> So should we change our fragno to be 0? >>> >>> br, >>> >>> -- >>> Monthadar Al Jaberi >>> _______________________________________________ >>> freebsd-wireless@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless >>> To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org" -- Monthadar Al Jaberi