From owner-svn-ports-all@freebsd.org  Sun Mar 11 23:38:09 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3361F30878;
 Sun, 11 Mar 2018 23:38:09 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 54ACA84FD3;
 Sun, 11 Mar 2018 23:38:09 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 4366C2167; Sun, 11 Mar 2018 23:38:09 +0000 (UTC)
Date: Sun, 11 Mar 2018 23:38:09 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r464197 - head/lang/see
Message-ID: <20180311233809.GA46270@FreeBSD.org>
References: <201803111946.w2BJkQcD053063@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201803111946.w2BJkQcD053063@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Mar 2018 23:38:09 -0000

On Sun, Mar 11, 2018 at 07:46:26PM +0000, Sunpoet Po-Chuan Hsieh wrote:
> New Revision: 464197
> URL: https://svnweb.freebsd.org/changeset/ports/464197
> 
> Log:
>   Expand _LICENSE_PERMS_DEFAULT

Again, you're simply translating made changes in English, not actually
explaining them.  This is not right.  It leaves people wondering what
problem are you trying to fix and/or what are you trying to achieve by
these changes.  Please try to add a few words describing those things.

./danfe

> @@ -18,7 +18,7 @@ LICENSE_COMB=	multi
>  LICENSE_NAME_DTOA.C=	License of dtoa.c
>  LICENSE_FILE_BSD3CLAUSE=	${WRKSRC}/COPYING
>  LICENSE_FILE_DTOA.C=	${WRKSRC}/COPYING
> -LICENSE_PERMS_DTOA.C=	${_LICENSE_PERMS_DEFAULT}
> +LICENSE_PERMS_DTOA.C=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept