Date: Mon, 13 Apr 2009 02:16:38 GMT From: Andrew Turner <andrew@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 160546 for review Message-ID: <200904130216.n3D2GcK6071548@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=160546 Change 160546 by andrew@andrew_bender on 2009/04/13 02:16:38 In s3c24{1,4}0_clock_freq2 make the dividers and temporary values unsigned as they should never be negative. Affected files ... .. //depot/projects/arm/src/sys/arm/s3c2xx0/s3c24x0.c#10 edit Differences ... ==== //depot/projects/arm/src/sys/arm/s3c2xx0/s3c24x0.c#10 (text+ko) ==== @@ -433,8 +433,8 @@ s3c2410_clock_freq2(vm_offset_t clkman_base, int *fclk, int *hclk, int *pclk) { uint32_t pllcon, divn; - int mdiv, pdiv, sdiv; - int f, h, p; + unsigned int mdiv, pdiv, sdiv; + unsigned int f, h, p; pllcon = *(volatile uint32_t *)(clkman_base + CLKMAN_MPLLCON); divn = *(volatile uint32_t *)(clkman_base + CLKMAN_CLKDIVN); @@ -460,8 +460,8 @@ s3c2440_clock_freq2(vm_offset_t clkman_base, int *fclk, int *hclk, int *pclk) { uint32_t pllcon, divn, camdivn; - int mdiv, pdiv, sdiv; - int f, h, p; + unsigned int mdiv, pdiv, sdiv; + unsigned int f, h, p; pllcon = *(volatile uint32_t *)(clkman_base + CLKMAN_MPLLCON); divn = *(volatile uint32_t *)(clkman_base + CLKMAN_CLKDIVN);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904130216.n3D2GcK6071548>